Fix GetSystemCMD concatenating flags without spaces#397
Merged
Conversation
Every flag appended in GetSystemCMD() was missing a leading space, producing malformed output like "-enable_shadows-shadow_quality 2-aa" instead of "-enable_shadows -shadow_quality 2 -aa". FSO would receive all system flags merged into one unparseable token. The PlayMod call path happened to work by accident because it splits the result on '-' before passing it to CmdLineBuilder, but the output was wrong by contract and would break any caller that used it directly.
Shivansps
approved these changes
May 6, 2026
Member
Shivansps
left a comment
Shivansps
left a comment
There was a problem hiding this comment.
Im going to aprove it but im a bit concerned that it may create problems while doing comparisons. I think it will not but, we need to check that the cmd priority still work for these cmdline arguments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every flag appended in GetSystemCMD() was missing a leading space, producing malformed output like "-enable_shadows-shadow_quality 2-aa" instead of "-enable_shadows -shadow_quality 2 -aa". FSO would receive all system flags merged into one unparseable token.
The PlayMod call path happened to work by accident because it splits the result on '-' before passing it to CmdLineBuilder, but the output was wrong by contract and would break any caller that used it directly.