Fix 504 Gateway Timeout falsely reported as success in Nebula API calls#400
Merged
Conversation
Previously, a GatewayTimeout response from any of mod/release,
mod/release/update, mod/release/delete, or multiupload/finish was
silently converted into a fabricated { result: true } reply, causing
the UI to report success when the server may never have processed the
request.
- multiupload/finish: now returns null on 504, allowing Finish() to use
its existing retry loop and CheckUploadDone() verification path rather
than bypassing it with a fake success.
- mod/release, mod/release/update, mod/release/delete: now return a
non-null ApiReply with gatewayTimeout=true (result=false). The three
callers (ReleaseMod, UpdateMetaData, DeleteModVersion) surface a clear
warning asking the user to verify the operation on the Nebula website,
rather than silently claiming it succeeded.
Also fixes the 504 status code check from a fragile .ToString()
string comparison to the correct HttpStatusCode enum value.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Shivansps
approved these changes
May 6, 2026
Contributor
|
Things still work as expected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, a GatewayTimeout response from any of mod/release, mod/release/update, mod/release/delete, or multiupload/finish was silently converted into a fabricated { result: true } reply, causing the UI to report success when the server may never have processed the request.
multiupload/finish: now returns null on 504, allowing Finish() to use its existing retry loop and CheckUploadDone() verification path rather than bypassing it with a fake success.
mod/release, mod/release/update, mod/release/delete: now return a non-null ApiReply with gatewayTimeout=true (result=false). The three callers (ReleaseMod, UpdateMetaData, DeleteModVersion) surface a clear warning asking the user to verify the operation on the Nebula website, rather than silently claiming it succeeded.
Also fixes the 504 status code check from a fragile .ToString() string comparison to the correct HttpStatusCode enum value.