add < and > to dependency version operators#402
Merged
Shivansps merged 1 commit intoKnossosNET:mainfrom May 10, 2026
Merged
Conversation
SastifiesDependency now supports strict-less and strict-greater in addition to the existing ~, >=, <=. Dev mod editor pickers now expose <=, >, and < (the first was already supported but unexposed, the latter two are new). Also fixes two latent bugs that mishandled the new operators: - InstallMod's FSO compression check missed <= and ~ in its strip chain, silently parsing to 0.0.0 - Mod.FilterDependencies miscategorized non-(>=, ~) deps as exact matches; they now pass through dedup unchanged
Goober5000
force-pushed
the
feature/more_operators
branch
from
1dd337e to
ca097b4
Compare
wookieejedi
approved these changes
May 10, 2026
Member
|
Just to add a note to this, the de-dup logic is very complex and has a design flaw, thats why < and <= were never added at the start, i dont think anyone is going to add duplicated depedencies on Knet so this is why im merging it. But keep in mind the de dup logic and the entire mod dependency system needs a total re-design and rework in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SastifiesDependency now supports strict-less and strict-greater in addition to the existing ~, >=, <=. Dev mod editor pickers now expose <=, >, and < (the first was already supported but unexposed, the latter two are new).
Also fixes two latent bugs that mishandled the new operators: