Support DFR0553 ADC water monitor readings#33
Merged
Conversation
Add a local ADS1115/DFR0553 I2C ADC driver and wire pH, EC, and ORP readings through it with analogRead fallback. Keep the enhanced WaterMonitor services in the same commit because the sketch references them and the verified build depends on them. Constraint: DFR0553 support must not add a new external ADS1115 dependency Rejected: Depend on the DFRobot ADS1115 library | a compact local driver keeps Arduino setup simpler Confidence: high Scope-risk: moderate Directive: Keep DFR0553 channel mapping centralized in ArduinoUnoDo/WaterMonitor/config.h Tested: git diff --cached --check Tested: arduino-cli compile --fqbn esp32:esp32:esp32 ArduinoUnoDo/WaterMonitor Not-tested: Physical DFR0553 wiring and sensor readings on hardware
Merge the current KnowFlow master into PR 33 and reconcile the overlapping ArduinoUnoDo configuration, README, and sensor hub changes. The conflict resolution keeps upstream's unified sensor numbering and ESP32 additions while preserving the DFR0553 ADC path for pH, EC, and ORP. Constraint: PR 33 must merge into KnowFlow/master without conflict Rejected: Drop upstream config unification | required by the target branch Rejected: Drop DFR0553 wiring | it is the purpose of PR 33 Confidence: high Scope-risk: moderate Directive: Keep ArduinoUnoDo sensor indexes based on SensorNumber enum and DFR0553 channel mapping in config.h Tested: rg '<<<<<<<|>>>>>>>' README.md ArduinoUnoDo/WaterMonitor ArduinoESP32 Firmware ArduinoUnoGravityDo .github .cursor Tested: git diff --check -- README.md ArduinoUnoDo/WaterMonitor/config.h ArduinoUnoDo/WaterMonitor/WaterMonitor.ino ArduinoUnoDo/WaterMonitor/GravitySensorHub.h ArduinoUnoDo/WaterMonitor/GravitySensorHub.cpp Tested: arduino-cli compile --fqbn esp32:esp32:esp32 ArduinoUnoDo/WaterMonitor Not-tested: Hardware DFR0553 readings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a local ADS1115/DFR0553 I2C ADC driver and wire pH, EC, and ORP readings through it with analogRead fallback. Keep the enhanced WaterMonitor services in the same commit because the sketch references them and the verified build depends on them.
Constraint: DFR0553 support must not add a new external ADS1115 dependency
Rejected: Depend on the DFRobot ADS1115 library | a compact local driver keeps Arduino setup simpler
Confidence: high
Scope-risk: moderate
Directive: Keep DFR0553 channel mapping centralized in ArduinoUnoDo/WaterMonitor/config.h
Tested: git diff --cached --check
Tested: arduino-cli compile --fqbn esp32:esp32:esp32 ArduinoUnoDo/WaterMonitor
Not-tested: Physical DFR0553 wiring and sensor readings on hardware