Similarity threshold is hardcoded

[dgarijo]

In the similarity based analysis with headers, the threshold is set to a fixed value of 0.8. This should be editable from the configuration of Somef.

This parameter will not be exposed as it could be confused with the confidence from the supervised classifiers.

Class: header_analysis.py

[juanjemdIos]

Dani Im not sure if this should be in constanst.py or in config.json. Or maybe both?

[dgarijo]

The threshold is passed optionally with the -t option.

[juanjemdIos]

oops I've uploaded this right now. But I don't understand. I thought the -t parameter it was different from the constant similarity_thresshold of header_analysis. At least in the code it was something different

[dgarijo]

the -t is a threshold. It is true that is not exactly the same. So it's fine if we can set it up as a config parameter

[juanjemdIos]

So... probably we need a small explanation about this, right? I'm sure you are going to ask me for that :).
But should this be done in the readme or is there another doc more suitable?

[dgarijo]

We can add it in the documentation