new properties (license, version) from citation.cff. Fixes #935#948
Merged
dgarijo merged 20 commits intoKnowledgeCaptureAndDiscovery:devfrom Apr 16, 2026
Merged
new properties (license, version) from citation.cff. Fixes #935#948dgarijo merged 20 commits intoKnowledgeCaptureAndDiscovery:devfrom
dgarijo merged 20 commits intoKnowledgeCaptureAndDiscovery:devfrom
Conversation
Collaborator
|
@juanjemdIos what about the info from the reference publication? |
…TATION. But using is_preferred_citation. Improve test and referencePublication/authors in parser codemeta. Fixes KnowledgeCaptureAndDiscovery#957
dgarijo
reviewed
Apr 14, 2026
dgarijo
reviewed
Apr 14, 2026
| - **Build file**: Build file(s) of the project. For example, files used to create a Docker image for the target software, package files, etc. | ||
| - **Citation**: Preferred citation as the authors have stated in their readme file. SOMEF recognizes Bibtex, Citation File Format files and other means by which authors cite their papers (e.g., by in-text citation). We aim to recognize the following properties: | ||
| - **Citation**: Preferred citation(s) as the authors have stated in their readme file. SOMEF recognizes Bibtex, Citation File Format files and other means by which authors cite their papers (e.g., by in-text citation). | ||
| For CITATION.cff files, SOMEF now generates two separate entries: one for the software (is_preferred_citation: False) and another for the preferred citation (is_preferred_citation: True). This ensures metadata like DOI or version is correctly assigned to each entity. |
Collaborator
There was a problem hiding this comment.
but if there is no preferred citation, then the software one is not false.
Instead of generating False, I would only leave is_preferred_citaiton: True when we find prefered citation. And do not add anything otherwise.
dgarijo
reviewed
Apr 14, 2026
dgarijo
reviewed
Apr 14, 2026
dgarijo
reviewed
Apr 14, 2026
dgarijo
reviewed
Apr 14, 2026
| - `forks_url`: Links to forks made of the project (GitHub only) | ||
| - `full_name`: Name + owner (owner/name) (if available) | ||
| - `full_title`: If the repository has a short name, we will attempt to extract the longer version of the repository name. For example, a repository may be called "Widoco", but the longer title is "Wizard for documenting ontologies". | ||
| - `funding`: Funding code for the related project. |
dgarijo
reviewed
Apr 14, 2026
| |---|---|---| | ||
| | **name** | String | Name of the requeriment | | ||
| | **version** | String | named version of a requeriment | | ||
| | **dependency_type** | String | type: dev, runtime... Indicates whether the dependency is required at runtime or only for development/testing | |
Collaborator
There was a problem hiding this comment.
List all dependency types we support.
We support 3: development, runtime and documentation
dgarijo
reviewed
Apr 14, 2026
|
|
||
|
|
||
| A SOFTWARE_APPLICATION has the following properties: | ||
| A Software_application has the following properties: |
Collaborator
There was a problem hiding this comment.
This one does not make a lot of sense. What is the difference between this and Requirement?
dgarijo
reviewed
Apr 14, 2026
| json_content = json.loads(data) | ||
|
|
||
| copyright_holder = json_content[constants.CAT_CODEMETA_COPYRIGHTHOLDER] | ||
| print(copyright_holder) |
Collaborator
There was a problem hiding this comment.
do not print. Log or remove pls
dgarijo
reviewed
Apr 14, 2026
dgarijo
requested changes
Apr 14, 2026
Collaborator
dgarijo
left a comment
dgarijo
left a comment
There was a problem hiding this comment.
Please see the required changes
Co-authored-by: Daniel Garijo <dgarijov@gmail.com>
Co-authored-by: Daniel Garijo <dgarijov@gmail.com>
Co-authored-by: Daniel Garijo <dgarijov@gmail.com>
# Conflicts: # docs/index.md
dgarijo
reviewed
Apr 16, 2026
dgarijo
reviewed
Apr 16, 2026
dgarijo
reviewed
Apr 16, 2026
dgarijo
reviewed
Apr 16, 2026
dgarijo
reviewed
Apr 16, 2026
dgarijo
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.