Skip to content

Feature/verify api#405

Merged
JayDwee merged 9 commits intomasterfrom
feature/verify-api
Apr 18, 2023
Merged

Feature/verify api#405
JayDwee merged 9 commits intomasterfrom
feature/verify-api

Conversation

@JayDwee
Copy link
Copy Markdown
Member

@JayDwee JayDwee commented Apr 17, 2023

Summary

close #397

Checklist

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

  • Have you tested the changes? (pytest & dpytest)
  • Have you followed PEP-8 for naming and styling?
  • Has your code been properly documented with RestructuredText docstrings?
  • Have you added your changes to CHANGELOG.md under the [Unreleased] heading?
  • If your code added new bot commands, have you updated documentation.json?

  • All of this code is your own, or follows the author repo's licence.

@JayDwee JayDwee requested a review from abluey April 17, 2023 19:39
@JayDwee JayDwee self-assigned this Apr 17, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2023

Codecov Report

Merging #405 (0f8d07b) into master (44492c8) will decrease coverage by 0.04%.
The diff coverage is 90.47%.

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
- Coverage   87.39%   87.35%   -0.04%     
==========================================
  Files         119      123       +4     
  Lines        8750     8916     +166     
==========================================
+ Hits         7647     7789     +142     
- Misses       1103     1127      +24     
Flag Coverage Δ
unittests 87.35% <90.47%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
koala/cogs/announce/db.py 100.00% <ø> (ø)
koala/cogs/colour_role/cog.py 88.10% <ø> (ø)
koala/cogs/colour_role/models.py 88.88% <ø> (ø)
koala/cogs/react_for_role/api.py 91.66% <ø> (ø)
koala/cogs/react_for_role/utils.py 100.00% <ø> (ø)
koala/cogs/twitch_alert/env.py 100.00% <ø> (ø)
koala/cogs/twitch_alert/models.py 92.68% <ø> (ø)
koala/cogs/verification/env.py 100.00% <ø> (ø)
koala/env.py 81.25% <ø> (ø)
tests/cogs/base/test_cog.py 100.00% <ø> (ø)
... and 60 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


class VerifyEndpoint:
"""
The API endpoints for BaseCog
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this should mean verify cog instead of base cog?

@abluey
Copy link
Copy Markdown
Contributor

abluey commented Apr 18, 2023

All the code looks good, though is db file really needed in verification? I moved the blacklist stuff there but every other db action was executed in core anyway 🤔

@JayDwee JayDwee merged commit 4a6f82a into master Apr 18, 2023
@JayDwee JayDwee deleted the feature/verify-api branch April 18, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verify API implementation

2 participants