Skip to content

Conversation

@jmsche
Copy link
Contributor

@jmsche jmsche commented Aug 28, 2024

Q A
Bug fix? no
New feature? no
Tests pass? yes
Fixed tickets N/A

Hi, this PR fixes the following deprecations I get:

  • Method "Symfony\Component\DependencyInjection\Extension\ExtensionInterface::load()" might add "void" as a native return type declaration in the future. Do the same in implementation "Kocal\BiomeJsBundle\DependencyInjection\BiomeJsExtension" now to avoid errors or add an explicit @return annotation to suppress this message.
  • Method "Symfony\Component\Console\Command\Command::initialize()" might add "void" as a native return type declaration in the future. Do the same in child class "Kocal\BiomeJsBundle\Command\BiomeJsCiCommand" now to avoid errors or add an explicit @return annotation to suppress this message.
  • Method "Symfony\Component\Console\Command\Command::initialize()" might add "void" as a native return type declaration in the future. Do the same in child class "Kocal\BiomeJsBundle\Command\BiomeJsCheckCommand" now to avoid errors or add an explicit @return annotation to suppress this message.

@Kocal Kocal merged commit 1ef6b11 into Kocal:main Aug 28, 2024
@Kocal
Copy link
Owner

Kocal commented Aug 28, 2024

Thank you! :)

@jmsche jmsche deleted the fix-deprecations branch August 28, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants