Add MethodsShouldBePublicOrPrivateRule
#7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
force-pushed
the
MethodsShouldBePublicOrPrivateRule
branch
from
5e5a777 to
4b52686
Compare
Copilot finished reviewing on behalf of
Kocal
November 23, 2025 18:23
Kocal
force-pushed
the
MethodsShouldBePublicOrPrivateRule
branch
from
4b52686 to
7da321b
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds a new PHPStan rule MethodsShouldBePublicOrPrivateRule that enforces method visibility constraints for Symfony UX Twig Components. The rule ensures that methods in Twig Components (including Live Components) are either public or private, but never protected, since components must be final classes where protected methods serve no purpose.
Key changes:
- Implements
MethodsShouldBePublicOrPrivateRulefollowing established patterns for Twig Component rules - Adds comprehensive test coverage for both
#[AsTwigComponent]and#[AsLiveComponent]attributes - Configures ECS to skip
ProtectedToPrivateFixerfor test fixtures that intentionally use protected methods
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Rules/TwigComponent/MethodsShouldBePublicOrPrivateRule.php | Implements the new PHPStan rule that detects protected methods in Twig Components |
| tests/Rules/TwigComponent/MethodsShouldBePublicOrPrivateRule/MethodsShouldBePublicOrPrivateRuleTest.php | Test case with separate violation and no-violation test methods |
| tests/Rules/TwigComponent/MethodsShouldBePublicOrPrivateRule/config/configured_rule.neon | PHPStan configuration to enable the rule for tests |
| tests/Rules/TwigComponent/MethodsShouldBePublicOrPrivateRule/Fixture/*.php | Test fixtures covering all scenarios: violations with both attribute types, valid components, and non-components |
| ecs.php | Skips ProtectedToPrivateFixer for test fixtures that intentionally use protected methods |
| phpstan-baseline.neon | Adds baseline entries for intentionally unused private methods in test fixtures |
| README.md | Documents the new rule with usage examples and rationale (contains 2 spelling errors) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Kocal
force-pushed
the
MethodsShouldBePublicOrPrivateRule
branch
from
7da321b to
d550c76
Compare
Kocal
force-pushed
the
MethodsShouldBePublicOrPrivateRule
branch
from
d550c76 to
41ea205
Compare
Copilot finished reviewing on behalf of
Kocal
November 23, 2025 18:29
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.