Skip to content

Add opportuntity to create ImageBoards collection via constructor#120

Merged
Kodehawa merged 1 commit intoKodehawa:masterfrom
InsanusMokrassar:feature/creatable_ImageBoards
Dec 5, 2023
Merged

Add opportuntity to create ImageBoards collection via constructor#120
Kodehawa merged 1 commit intoKodehawa:masterfrom
InsanusMokrassar:feature/creatable_ImageBoards

Conversation

@InsanusMokrassar
Copy link
Copy Markdown
Contributor

No description provided.

@InsanusMokrassar InsanusMokrassar changed the title add opportuntity to create ImageBoards collection via constructor Add opportuntity to create ImageBoards collection via constructor Oct 13, 2023
@InsanusMokrassar InsanusMokrassar marked this pull request as draft October 13, 2023 06:42
@InsanusMokrassar InsanusMokrassar marked this pull request as ready for review October 13, 2023 06:43
@Kodehawa
Copy link
Copy Markdown
Owner

Kodehawa commented Dec 2, 2023

I see no issues here, mind if I get a little explanation as to why and what you changed? For the commit message.

Also whether this breaks anything or not (seems like no)

@InsanusMokrassar
Copy link
Copy Markdown
Contributor Author

I see no issues here, mind if I get a little explanation as to why and what you changed? For the commit message.

Also whether this breaks anything or not (seems like no)

This update gives opportunity to create own independent collection with its own settings. For example, you may setup OkHttpClient as you wish and get full collection of boards

I have changed old API to without breaking changes :)

@Kodehawa Kodehawa merged commit 757fe52 into Kodehawa:master Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants