-
Notifications
You must be signed in to change notification settings - Fork 86
fix issue#98 : adding column_table_limit feature #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| The column limit of one line for table. Default value is same as column_limit value. | ||
|
|
||
| ```lua |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the examples to something like:
column_table_limit: column_limit
[...]
column_table_limit: 20
[...]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
docs/Style-Config.md
Outdated
|
|
||
| type: int, default: column_limit | ||
|
|
||
| The column limit of one line for table. Default value is same as column_limit value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The column limit of one line for table. Default value is same as column_limit value. | |
| The column limit of each line of a table. Default value the same as column_limit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
@karanankit01 squash the commits into 2. Fixes for commits not yet merged should not go to |
| chop_down_table: false | ||
| chop_down_kv_table: true | ||
| table_sep: "," | ||
| column_table_limit: column_limit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value of column_table_limit is not a reference to column_limit .
Consider this config file:
column_limit: 120The value of column_table_limit is 80, not 120.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I figured it out.
I fixed it by checking the config file and updating its value with column_limit .
4a649b2 to
00026e8
Compare
src/Config.cpp
Outdated
| if (node_[key]) { | ||
| node_[key] = kv.second; | ||
| } | ||
| if(key == CTL) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this code is not formatted correctly.
use clang-format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Thanks, I will mind it from now.
by default the column_table_limit is same as column_limit.
User can set the value of column_table_limit in type int.
as discussed in issue#98