Skip to content

Conversation

@karanankit01
Copy link
Contributor

by default the column_table_limit is same as column_limit.
User can set the value of column_table_limit in type int.
as discussed in issue#98


The column limit of one line for table. Default value is same as column_limit value.

```lua
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the examples to something like:

column_table_limit: column_limit
[...]
column_table_limit: 20
[...]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


type: int, default: column_limit

The column limit of one line for table. Default value is same as column_limit value.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The column limit of one line for table. Default value is same as column_limit value.
The column limit of each line of a table. Default value the same as column_limit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@tammela
Copy link
Contributor

tammela commented May 8, 2020

@karanankit01 squash the commits into 2.
One that adds the feature and one that adds the documentation.

Fixes for commits not yet merged should not go to master.

chop_down_table: false
chop_down_kv_table: true
table_sep: ","
column_table_limit: column_limit
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value of column_table_limit is not a reference to column_limit .
Consider this config file:

column_limit: 120

The value of column_table_limit is 80, not 120.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I figured it out.
I fixed it by checking the config file and updating its value with column_limit .

@karanankit01 karanankit01 force-pushed the cov-test branch 4 times, most recently from 4a649b2 to 00026e8 Compare May 8, 2020 15:59
src/Config.cpp Outdated
if (node_[key]) {
node_[key] = kv.second;
}
if(key == CTL) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this code is not formatted correctly.
use clang-format.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Thanks, I will mind it from now.

@Koihik Koihik merged commit 897275f into Koihik:master May 13, 2020
@karanankit01 karanankit01 deleted the cov-test branch May 16, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants