added test and fix for persistence#1237
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Fixes a ratings overlay persistence bug where Quickstart could overwrite already-saved Rotten Tomatoes mass rating sources with badge-derived defaults when revisiting the Libraries page.
The overlay sync logic now defaults sources only when they are unset, while preserving existing valid selections such as
plex_tomatoesandplex_tomatoesaudience. This PR also adds an e2e regression test covering both behaviors: preserve on existing values, default on empty values.Related Issues [optional]
Which Environment Did You Test On?
python quickstart.py)