feat: Added changes to support CRUD oprn for graphql ratelimiting cos…#1937
feat: Added changes to support CRUD oprn for graphql ratelimiting cos…#1937shivaygupta-dotcom wants to merge 15 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1937 +/- ##
==========================================
+ Coverage 33.54% 33.58% +0.04%
==========================================
Files 76 76
Lines 6711 6711
==========================================
+ Hits 2251 2254 +3
+ Misses 4280 4278 -2
+ Partials 180 179 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
fix for CI is already raised by @Prashansa-K in this PR |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 27577943 | Triggered | Generic High Entropy Secret | d1d63e8 | tests/integration/testdata/dump/009-skip-defaults/enterprise/3.4/credentials.expected.yaml | View secret |
| 27577964 | Triggered | Generic Password | d1d63e8 | tests/integration/testdata/dump/009-skip-defaults/enterprise/3.4/credentials.expected.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
GH issue: #1909
jira: https://konghq.atlassian.net/browse/FTI-7307
Summary:
graphql_ratelimiting_cost_decorations.Supporting PRs:
GDR: Kong/go-database-reconciler#428
Go-kong: Kong/go-kong#602