fix: validating passed address and workspace params before creating a http target#1946
Merged
Prashansa-K merged 4 commits intomainfrom Mar 23, 2026
Merged
fix: validating passed address and workspace params before creating a http target#1946Prashansa-K merged 4 commits intomainfrom
Prashansa-K merged 4 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1946 +/- ##
==========================================
- Coverage 33.54% 33.51% -0.04%
==========================================
Files 76 76
Lines 6711 6726 +15
==========================================
+ Hits 2251 2254 +3
- Misses 4280 4293 +13
+ Partials 180 179 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Prashansa-K
requested review from
harshadixit12 and
shivaygupta-dotcom
and removed request for
shivaygupta-dotcom
cmd/common.go
Outdated
| return "", err | ||
| } | ||
| // Validate address scheme before constructing the fallback URL. | ||
| if err := validateAddress(reconcilerUtils.CleanAddress(config.Address)); err != nil { |
Contributor
There was a problem hiding this comment.
One nit - if we store the returned value from reconcilerUtils.CleanAddress(config.Address), we can avoid a subsequent call in line 796
LGTM other than this.
harshadixit12
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: https://konghq.atlassian.net/browse/APIOP-2