Skip to content

fix: Added test for upstream target weight update and moved update method from PATCH to PUT in go-kong#1956

Merged
Prashansa-K merged 9 commits intomainfrom
fix/decK-1894
Apr 9, 2026
Merged

fix: Added test for upstream target weight update and moved update method from PATCH to PUT in go-kong#1956
Prashansa-K merged 9 commits intomainfrom
fix/decK-1894

Conversation

@shivaygupta-dotcom
Copy link
Copy Markdown
Contributor

@shivaygupta-dotcom shivaygupta-dotcom commented Mar 26, 2026

Issue: #1894

Summary:

  1. decK sync was failing when modifying upstream target weights in Konnect because the update operation in target CRUD used the PATCH endpoint, which is not supported by Konnect. This has been fixed by switching the update operation to use PUT instead.
  2. Added test for both kong and konnect to verify nothing should break after moving to PUT endpoint.

@shivaygupta-dotcom shivaygupta-dotcom changed the title Fix/dec k 1894 fix: Added test for upstream target weight update and moved update method from PATCH to PUT in go-kong Mar 26, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.94%. Comparing base (d7a8236) to head (7155ebf).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1956   +/-   ##
=======================================
  Coverage   32.94%   32.94%           
=======================================
  Files          77       77           
  Lines        6975     6975           
=======================================
  Hits         2298     2298           
  Misses       4493     4493           
  Partials      184      184           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shivaygupta-dotcom shivaygupta-dotcom marked this pull request as ready for review March 26, 2026 09:21
@Prashansa-K
Copy link
Copy Markdown
Contributor

PR looks fine. We can merge post go-kong update.

@gitguardian
Copy link
Copy Markdown

gitguardian bot commented Mar 27, 2026

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@shivaygupta-dotcom
Copy link
Copy Markdown
Contributor Author

PR looks fine. We can merge post go-kong update.

@Prashansa-K Can you pls approve this, customer is asking release timeline for this.
https://konghq.atlassian.net/browse/FTI-7293?focusedCommentId=211067

@Prashansa-K
Copy link
Copy Markdown
Contributor

PR looks fine. We can merge post go-kong update.

@Prashansa-K Can you pls approve this, customer is asking release timeline for this. https://konghq.atlassian.net/browse/FTI-7293?focusedCommentId=211067

Need a go-kong update. We can't release with a commit-id in go.mod
Plus, our CI is blocked.
Let them know that we can release by end of this week.

github.com/kong/go-database-reconciler v1.33.0/go.mod h1:CTFu9hfOh2L4qPniCUCqLYhKiuVA0UsQe0Iv4jZc58o=
github.com/kong/go-database-reconciler v1.35.0 h1:36Lmik7eoNMl+B/g6beWqBVgGl8b2vLXwNYNUVOtdRM=
github.com/kong/go-database-reconciler v1.35.0/go.mod h1:AeQNEbEQ/Wy3OwJiWIo3PwWCWfav25F/FsTESqbelac=
github.com/kong/go-kong v0.73.0 h1:Ct4EHJsJqoaYod39+gGy/JnU1664jzDbxTS2dk6Y628=
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed unused sum entries post running go mod tidy

@Prashansa-K Prashansa-K merged commit 36bac01 into main Apr 9, 2026
40 of 41 checks passed
@Prashansa-K Prashansa-K deleted the fix/decK-1894 branch April 9, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants