fix: Added test for upstream target weight update and moved update method from PATCH to PUT in go-kong#1956
Conversation
…thod from PATCH to PUT in go-kong
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1956 +/- ##
=======================================
Coverage 32.94% 32.94%
=======================================
Files 77 77
Lines 6975 6975
=======================================
Hits 2298 2298
Misses 4493 4493
Partials 184 184 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
PR looks fine. We can merge post go-kong update. |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
@Prashansa-K Can you pls approve this, customer is asking release timeline for this. |
Need a go-kong update. We can't release with a commit-id in go.mod |
| github.com/kong/go-database-reconciler v1.33.0/go.mod h1:CTFu9hfOh2L4qPniCUCqLYhKiuVA0UsQe0Iv4jZc58o= | ||
| github.com/kong/go-database-reconciler v1.35.0 h1:36Lmik7eoNMl+B/g6beWqBVgGl8b2vLXwNYNUVOtdRM= | ||
| github.com/kong/go-database-reconciler v1.35.0/go.mod h1:AeQNEbEQ/Wy3OwJiWIo3PwWCWfav25F/FsTESqbelac= | ||
| github.com/kong/go-kong v0.73.0 h1:Ct4EHJsJqoaYod39+gGy/JnU1664jzDbxTS2dk6Y628= |
There was a problem hiding this comment.
removed unused sum entries post running go mod tidy
Issue: #1894
Summary: