Skip to content

Support nested ssl_verify fields#1989

Merged
Prashansa-K merged 2 commits intomainfrom
314-ssl-verify-updates
Apr 9, 2026
Merged

Support nested ssl_verify fields#1989
Prashansa-K merged 2 commits intomainfrom
314-ssl-verify-updates

Conversation

@mheap
Copy link
Copy Markdown
Member

@mheap mheap commented Apr 9, 2026

The previous implementation assumed that ssl_verify was at the top level of all configurations. This isn't true - the new implementation fixes nested values as expected.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 82.08955% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.94%. Comparing base (f5fe146) to head (2690bd1).

Files with missing lines Patch % Lines
convert/plugin_updates_314.go 82.08% 8 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1989      +/-   ##
==========================================
+ Coverage   32.52%   32.94%   +0.41%     
==========================================
  Files          77       77              
  Lines        6914     6975      +61     
==========================================
+ Hits         2249     2298      +49     
- Misses       4485     4493       +8     
- Partials      180      184       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Prashansa-K Prashansa-K added skip-konnect Skip Konnect Integration tests in CI skip-ee Skip Enterprise Integration Tests in CI skip-oss Skip Open Source Integration Tests in CI labels Apr 9, 2026
@Prashansa-K Prashansa-K merged commit d7a8236 into main Apr 9, 2026
12 checks passed
@Prashansa-K Prashansa-K deleted the 314-ssl-verify-updates branch April 9, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-ee Skip Enterprise Integration Tests in CI skip-konnect Skip Konnect Integration tests in CI skip-oss Skip Open Source Integration Tests in CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants