Skip to content

Revert "feat: Add github release update check"#2016

Merged
harshadixit12 merged 1 commit intomainfrom
revert-1988-version-update-check
Apr 15, 2026
Merged

Revert "feat: Add github release update check"#2016
harshadixit12 merged 1 commit intomainfrom
revert-1988-version-update-check

Conversation

@harshadixit12
Copy link
Copy Markdown
Contributor

@harshadixit12 harshadixit12 commented Apr 15, 2026

Reverts #1988

Reason: to avoid calls to github in the hot path.

To do before merging it back -

  1. Reduce timeout (maybe ~500ms?)
  2. Cache to avoid frequent calls

Ref https://kongstrong.slack.com/archives/C07AQH7SAF8/p1776257365864819?thread_ts=1776256700.290769&cid=C07AQH7SAF8

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 32.91%. Comparing base (6528e6e) to head (e94fe3c).

Files with missing lines Patch % Lines
cmd/root.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2016       +/-   ##
===========================================
- Coverage   51.12%   32.91%   -18.21%     
===========================================
  Files          78       77        -1     
  Lines        7138     7064       -74     
===========================================
- Hits         3649     2325     -1324     
- Misses       3232     4544     +1312     
+ Partials      257      195       -62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@harshadixit12 harshadixit12 merged commit 84d35f9 into main Apr 15, 2026
44 checks passed
@harshadixit12 harshadixit12 deleted the revert-1988-version-update-check branch April 15, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants