test: preserve comment lines to hanlde big multi-line yamls#2019
test: preserve comment lines to hanlde big multi-line yamls#2019shivaygupta-dotcom merged 8 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2019 +/- ##
=======================================
Coverage 32.87% 32.87%
=======================================
Files 77 77
Lines 7064 7064
=======================================
Hits 2322 2322
Misses 4546 4546
Partials 196 196 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shivaygupta-dotcom
force-pushed
the
fix/render-template-comment-handling
branch
from
cfa8798 to
7e7c243
Compare
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 30400066 | Triggered | Generic High Entropy Secret | 1565eb5 | tests/integration/testdata/diff/004-no-diff-plugin/kong.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
| // test scope: | ||
| // - kong >=3.0.0 | ||
| func Test_RequestTermination_Dump_Diff(t *testing.T) { | ||
| runWhen(t, "kong", ">=3.0.0") |
There was a problem hiding this comment.
Let's run this for konnect as well?
There was a problem hiding this comment.
unless it is only happening when created via admin API
There was a problem hiding this comment.
this is only happening when created with adminAPI/ UI.
| testKongState(t, client, true, false, expectedStatePostSync, nil) | ||
| } | ||
|
|
||
| // Test_RequestTermination_Dump_Diff ensures that a create-via-API → dump → diff |
There was a problem hiding this comment.
LGTM - but lets move this to diff_test.go
3 participants
FTI: https://konghq.atlassian.net/browse/FTI-7356
supporting PR: Kong/go-database-reconciler#455