Skip to content

chore: add check on branch for tags#2070

Merged
harshadixit12 merged 2 commits into
mainfrom
chore/verify-tag-is-on-main-before-release
May 25, 2026
Merged

chore: add check on branch for tags#2070
harshadixit12 merged 2 commits into
mainfrom
chore/verify-tag-is-on-main-before-release

Conversation

@harshadixit12
Copy link
Copy Markdown
Contributor

Prevents release when wrong branch gets tagged, and ensures all tags remain on main.

https://kongstrong.slack.com/archives/C07AQH7SAF8/p1775674728426559

- name: Verify tag is on main
run: |
git fetch origin main
if ! git merge-base --is-ancestor ${{ github.sha }} origin/main; then
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git merge-base --is-ancestor ${{ github.sha }} origin/main returns 1 as exit code if not ancestor.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.64%. Comparing base (6ac11c1) to head (40dbb70).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2070   +/-   ##
=======================================
  Coverage   32.64%   32.64%           
=======================================
  Files          77       77           
  Lines        7135     7135           
=======================================
  Hits         2329     2329           
  Misses       4610     4610           
  Partials      196      196           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@harshadixit12 harshadixit12 added skip-konnect Skip Konnect Integration tests in CI skip-ee Skip Enterprise Integration Tests in CI skip-oss Skip Open Source Integration Tests in CI labels May 25, 2026
@harshadixit12 harshadixit12 requested a review from Prashansa-K May 25, 2026 06:15
@harshadixit12 harshadixit12 marked this pull request as ready for review May 25, 2026 06:15
@harshadixit12 harshadixit12 merged commit a789db5 into main May 25, 2026
11 checks passed
@harshadixit12 harshadixit12 deleted the chore/verify-tag-is-on-main-before-release branch May 25, 2026 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-ee Skip Enterprise Integration Tests in CI skip-konnect Skip Konnect Integration tests in CI skip-oss Skip Open Source Integration Tests in CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants