Skip to content

Adding "?" to path #25

@montanaflynn

Description

@montanaflynn

This line of code is adding a question mark to the end of paths even if they have no query string. I changed it but it broke some node tests, is this intentional?

Here's what I would have changed it to, since the path is set right above with just the pathname.

// add search property to path
if (this.source.uriObj.search) {
  this.source.uriObj.path = this.source.uriObj.pathname + '?' + this.source.uriObj.search
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions