Skip to content

feat(Git Project): Introducing Git Projects#8301

Closed
gatzjames wants to merge 33 commits into
Kong:developfrom
gatzjames:feat/git-project
Closed

feat(Git Project): Introducing Git Projects#8301
gatzjames wants to merge 33 commits into
Kong:developfrom
gatzjames:feat/git-project

Conversation

@gatzjames
Copy link
Copy Markdown
Contributor

@gatzjames gatzjames commented Jan 16, 2025 •
edited
Loading

Highlights:

  • Added new project type: Git
  • Git projects allow syncing the entire project using a single repository
  • Git projects have a single sync dropdown for commit/sync actions accessible from all project files

Todo/Next steps:

  • Consolidate Git action logic into a Git service.
  • Ensure all file types (Collection/Spec/Environment/MockServer) sync correctly
  • Use a YAML diff viewer to match the exported data (currently we use a JSON diff view)
  • Add UX for cloning a Git project into an organization
  • Expand e2e tests

Closes INS-4248

@gatzjames gatzjames self-assigned this Jan 16, 2025
github-advanced-security[bot]
github-advanced-security AI found potential problems Jan 16, 2025
View reviewed changes
Comment thread packages/insomnia/src/ui/routes/git-project-actions.tsx

const baseDir = path.join(
process.env['INSOMNIA_DATA_PATH'] || window.app.getPath('userData'),
`version-control/git/${gitRepository._id}`

Check warning

Code scanning / Semgrep OSS

Semgrep Finding: javascript.lang.security.audit.path-traversal.path-join-resolve-traversal.path-join-resolve-traversal

Detected possible user input going into a `path.join` or `path.resolve` function. This could possibly lead to a path traversal vulnerability, where the attacker can access arbitrary files stored in the file system. Instead, be sure to sanitize or validate user input first.
Comment thread packages/insomnia/src/ui/routes/git-project-actions.tsx
const gitDataClient = fsClient(baseDir);

// All data outside the directories listed below will be stored in an 'other' directory. This is so we can support files that exist outside the ones the app is specifically in charge of.
const otherDataClient = fsClient(path.join(baseDir, 'other'));

Check warning

Code scanning / Semgrep OSS

Semgrep Finding: javascript.lang.security.audit.path-traversal.path-join-resolve-traversal.path-join-resolve-traversal

Detected possible user input going into a `path.join` or `path.resolve` function. This could possibly lead to a path traversal vulnerability, where the attacker can access arbitrary files stored in the file system. Instead, be sure to sanitize or validate user input first.
Comment thread packages/insomnia/src/ui/routes/git-project-actions.tsx Fixed
Comment thread packages/insomnia/src/ui/routes/git-project-actions.tsx Fixed
@gatzjames
schema
cac727e
@gatzjames
working imports
c212dc1
@gatzjames
exports
a1aec0d
@gatzjames
cleanup
184a1d3
@gatzjames
Move sortKey and description to meta and define request settings schema
96d272d
@gatzjames
request docs
2aec888
@gatzjames
export: cleanup empty fields
23e8478
@gatzjames
improve request settings
576950f
@gatzjames
update types and cleanup
d0d559d
@gatzjames
fix falsy value error
c8d48ba
@gatzjames
cleanup todo file
bb2eabc
@gatzjames
cleanup zod-to-json-schema
91cde34
@gatzjames
fix export ordering to imrpove readability
2823f85
@gatzjames
cleanup schema
761ab03
@gatzjames
update fixtures to v5
53de4be
@gatzjames
fix tests
910d68f
@gatzjames
clean up types and fix e2e tests
e4b006f
@gatzjames
importer in inso-cli
d84dc66
@gatzjames
update inso-cli e2e tests
ca90b8c
@gatzjames
update optional collection and spec meta
1e7d37f
@gatzjames
throw if no import found in inso
56b886a
@gatzjames
update inso error
653cfe2
@gatzjames
add docs for debugging inso
26ff5a9
@gatzjames
use action to create new projects
9f14300
@gatzjames
git project type
104ba9f
@gatzjames
git project vcs and fs clients
0018d9b
@gatzjames
Copy link
Copy Markdown
Contributor Author

gatzjames commented Feb 19, 2025

Closing in favor of #8382

@gatzjames gatzjames closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@gatzjames gatzjames

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gatzjames @github-advanced-security