fix(Git Sync): Fix credential validation causing form loop

[gatzjames]

Overview

Fixes an issue where selecting a repository to clone triggers a loop in the git repo form.

Fix:

• Credential validation check: Changed isCredentialInvalid to only treat non-idle state as invalid when no prior data exists (state !== 'idle' && !data), so revalidation after a successful validation no longer flickers the form.
• CSS hidden instead of unmount: Replaced conditional rendering ({!isCredentialInvalid && <Component>}) with CSS hidden class toggling for GitRepositorySelect and GitRemoteBranchSelect, keeping them mounted so fetcher state is preserved across revalidation cycles.

[Copilot]

Pull request overview

This PR addresses a UI loop in the Git Sync repository form by making credential revalidation less disruptive and preserving repository/branch selection state across validation cycles.

Changes:

• Adjusts credential validation logic to avoid treating all non-idle validation states as invalid when prior successful data exists.
• Replaces conditional unmounting of repository/branch selectors with CSS-based hiding to preserve fetcher/component state.
• Ensures the repository selection control participates in form submission by providing a name attribute.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
packages/insomnia/src/ui/components/project/git-repo-form.tsx	Updates credential-invalid logic and keeps repo/branch selectors mounted via hidden class toggling.
packages/insomnia/src/ui/components/git-credentials/git-repository-select.tsx	Adds name="uri" to the repository ComboBox for form submission.

Comments suppressed due to low confidence (2)

packages/insomnia/src/ui/components/project/git-repo-form.tsx:104

• isCredentialInvalid now treats a non-idle validation fetch as valid whenever validateCredentialFetcher.data is truthy. Because useFetcher data persists across load() calls, switching to a different credential can leave the previous credential’s success data in place while the new validation is still in-flight, keeping the form enabled/visible (and the submit button un-disabled) before the new credential is validated. Consider scoping the fetcher by selectedCredentialsId (e.g., useGitValidateCredentialFetcher({ key: selectedCredentialsId })) or tracking which credentialsId the current data corresponds to and marking invalid/loading when it doesn’t match the selected credential.

  const isCredentialInvalid =
    (validateCredentialFetcher.state !== 'idle' && !validateCredentialFetcher.data) ||
    Boolean(
      validateCredentialFetcher.data &&
        'errors' in validateCredentialFetcher.data &&
        validateCredentialFetcher.data.errors,
    );

packages/insomnia/src/ui/components/git-credentials/git-repository-select.tsx:55

• ComboBox is now given name="uri", but this component already appends its own <input type="hidden" name="uri" ... /> at the end. This results in multiple uri fields being submitted, which can make FormData.get('uri') ambiguous and may submit a different value than intended depending on element order/implementation. Prefer a single source of truth: either remove the custom hidden input and rely on the ComboBox’s name handling, or drop the name prop and keep the existing hidden input.

      <ComboBox
        aria-label="Repositories"
        name="uri"
        allowsCustomValue={false}
        className="w-full"
        isRequired
        isDisabled={loading}
        onSelectionChange={key => {

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.