Skip to content

test(e2e): add organization_team coverage to diff/command-coverage scenario#855

Merged
rspurgeon merged 3 commits intomainfrom
copilot/add-e2e-scenario-organization-team
Apr 22, 2026
Merged

test(e2e): add organization_team coverage to diff/command-coverage scenario#855
rspurgeon merged 3 commits intomainfrom
copilot/add-e2e-scenario-organization-team

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 22, 2026

  • Add organization.teams entry to testdata/config.yaml
  • Add organization.teams update in overlays/003-diff/config.yaml to trigger a diff
  • Update scenario.yaml vars, change counts, and assertions to cover organization_team
  • Make team ref and name distinct so UPDATE assertions validate resource_ref uses ref, DELETE assertions validate it uses name

Copilot AI changed the title [WIP] Add e2e scenario for organization_team declarative diff coverage test(e2e): add organization_team coverage to diff/command-coverage scenario Apr 22, 2026
Copilot AI requested a review from rspurgeon April 22, 2026 01:55
@rspurgeon rspurgeon marked this pull request as ready for review April 22, 2026 02:03
@rspurgeon rspurgeon requested review from a team as code owners April 22, 2026 02:03
Copilot AI review requested due to automatic review settings April 22, 2026 02:03
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds E2E diff coverage for organization_team resources in the existing diff/command-coverage scenario to ensure team field drift (notably description) is detected across diff modes.

Changes:

  • Add an organization.teams entry (diff-backend-team) to the base scenario config inputs.
  • Add an overlay variant of the same team with an updated description to force an UPDATE in diff output.
  • Extend the scenario to assert organization_team changes and adjust expected change counts accordingly.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
test/e2e/scenarios/diff/command-coverage/testdata/config.yaml Adds a baseline organization.teams team definition for the scenario’s initial state.
test/e2e/scenarios/diff/command-coverage/overlays/003-diff/config.yaml Adds an overlay that modifies the team description to produce an UPDATE during diff.
test/e2e/scenarios/diff/command-coverage/scenario.yaml Wires the new team into the end-to-end diff scenario and updates assertions + expected change counts.

Comment thread test/e2e/scenarios/diff/command-coverage/testdata/config.yaml Outdated
Comment thread test/e2e/scenarios/diff/command-coverage/overlays/003-diff/config.yaml Outdated
Comment thread test/e2e/scenarios/diff/command-coverage/scenario.yaml Outdated
@rspurgeon
Copy link
Copy Markdown
Collaborator

@copilot apply changes based on the comments in this thread

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 22, 2026

@copilot apply changes based on the comments in this thread

Done in 7137c71. All three files updated to use ref: diff-backend-team / name: diff-backend-team-name so the assertions are now meaningful: UPDATE assertions (apply/sync modes) check resource_ref == teamRef (diff-backend-team, the ref), while the DELETE assertion checks resource_ref == teamName (diff-backend-team-name, the name), matching the planner's documented behavior.

Copilot AI temporarily deployed to kongctl-acceptance-4 April 22, 2026 02:48 Inactive
Copilot AI temporarily deployed to kongctl-acceptance-5 April 22, 2026 02:48 Inactive
Copilot AI temporarily deployed to kongctl-acceptance-3 April 22, 2026 02:48 Inactive
Copilot AI temporarily deployed to kongctl-acceptance-2 April 22, 2026 02:48 Inactive
Copilot AI temporarily deployed to kongctl-acceptance April 22, 2026 02:48 Inactive
@rspurgeon rspurgeon merged commit 6b3b7e6 into main Apr 22, 2026
23 checks passed
@rspurgeon rspurgeon deleted the copilot/add-e2e-scenario-organization-team branch April 22, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[e2e-scan] Test: Add e2e scenario for organization_team declarative diff coverage

3 participants