Conversation
Agent-Logs-Url: https://github.com/Kong/kongctl/sessions/157cfeef-6cf6-40ba-873d-b3e5813f9990 Co-authored-by: rspurgeon <10521262+rspurgeon@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds E2E diff coverage for organization_team resources in the existing diff/command-coverage scenario to ensure team field drift (notably description) is detected across diff modes.
Changes:
- Add an
organization.teamsentry (diff-backend-team) to the base scenario config inputs. - Add an overlay variant of the same team with an updated description to force an
UPDATEin diff output. - Extend the scenario to assert
organization_teamchanges and adjust expected change counts accordingly.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
test/e2e/scenarios/diff/command-coverage/testdata/config.yaml |
Adds a baseline organization.teams team definition for the scenario’s initial state. |
test/e2e/scenarios/diff/command-coverage/overlays/003-diff/config.yaml |
Adds an overlay that modifies the team description to produce an UPDATE during diff. |
test/e2e/scenarios/diff/command-coverage/scenario.yaml |
Wires the new team into the end-to-end diff scenario and updates assertions + expected change counts. |
|
@copilot apply changes based on the comments in this thread |
Agent-Logs-Url: https://github.com/Kong/kongctl/sessions/3d19ac6f-2ffb-4165-9e2d-fd02e52b9cfe Co-authored-by: rspurgeon <10521262+rspurgeon@users.noreply.github.com>
Done in 7137c71. All three files updated to use |
organization.teamsentry totestdata/config.yamlorganization.teamsupdate inoverlays/003-diff/config.yamlto trigger a diffscenario.yamlvars, change counts, and assertions to coverorganization_teamrefandnamedistinct so UPDATE assertions validateresource_refuses ref, DELETE assertions validate it uses name