Skip to content

Task: Removed kai subcommand#893

Merged
rspurgeon merged 1 commit intomainfrom
gh-892-remove-kai
Apr 25, 2026
Merged

Task: Removed kai subcommand#893
rspurgeon merged 1 commit intomainfrom
gh-892-remove-kai

Conversation

@rspurgeon
Copy link
Copy Markdown
Collaborator

Summary

  • Remove the kongctl kai command registration and the Kai command package.
  • Delete the supporting internal/kai implementation, tests, TUI, storage, rendering, and API spec files.
  • Update README theme documentation and keep tableview markdown previews working without depending on the Kai package.
  • Run go mod tidy and required Go 1.26 modernization cleanup.

Validation

  • go fix ./...
  • make format
  • make build
  • make lint
  • make test
  • make test-integration
  • git grep confirmed no remaining Kai command/package references.

Closes #892

@rspurgeon rspurgeon changed the title [codex] remove kai subcommand Task: Removed kai subcommand Apr 25, 2026
@rspurgeon rspurgeon temporarily deployed to kongctl-acceptance-2 April 25, 2026 17:27 — with GitHub Actions Inactive
@rspurgeon rspurgeon temporarily deployed to kongctl-acceptance-5 April 25, 2026 17:27 — with GitHub Actions Inactive
@rspurgeon rspurgeon temporarily deployed to kongctl-acceptance-3 April 25, 2026 17:27 — with GitHub Actions Inactive
@rspurgeon rspurgeon temporarily deployed to kongctl-acceptance-4 April 25, 2026 17:27 — with GitHub Actions Inactive
@rspurgeon rspurgeon temporarily deployed to kongctl-acceptance April 25, 2026 17:27 — with GitHub Actions Inactive
@rspurgeon rspurgeon marked this pull request as ready for review April 25, 2026 17:27
@rspurgeon rspurgeon requested a review from a team as a code owner April 25, 2026 17:27
Copilot AI review requested due to automatic review settings April 25, 2026 17:27
@rspurgeon rspurgeon requested a review from a team as a code owner April 25, 2026 17:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the hidden/experimental kongctl kai subcommand and all supporting Kai implementation code, while keeping other interactive TUI features (notably kongctl view markdown previews) working independently of the removed Kai packages.

Changes:

  • Removed Kai command registration (verbs.Kai) and deleted the internal/cmd/root/verbs/kai command implementation.
  • Deleted the entire internal/kai implementation surface (API client, TUI, storage, rendering, specs, and tests).
  • Reworked markdown rendering in tableview to avoid depending on internal/kai/render, plus minor Go 1.26 modernizations (e.g., slices.Contains, reflect.TypeFor, reflect.Pointer, new(v) pointers).

Reviewed changes

Copilot reviewed 36 out of 38 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/konnect/helpers/portals.go Switches pagination pointer fields to new(...) style pointers.
internal/konnect/helpers/api_versions.go Updates pagination request fields to use new(...).
internal/konnect/helpers/api_publications.go Updates pagination request fields to use new(...).
internal/konnect/helpers/api_implementations.go Updates pagination request fields to use new(...).
internal/kai/tui/chat.go Deleted (removes Kai interactive TUI).
internal/kai/tasks_test.go Deleted (removes Kai task streaming tests).
internal/kai/tasks.go Deleted (removes Kai tasks API client).
internal/kai/storage/storage_test.go Deleted (removes Kai session storage tests).
internal/kai/storage/storage.go Deleted (removes Kai session storage implementation).
internal/kai/render/render.go Deleted (removes Kai markdown renderer wrapper).
internal/kai/logger.go Deleted (removes Kai context logging helpers).
internal/kai/errors.go Deleted (removes Kai transient error helpers).
internal/kai/chat_test.go Deleted (removes Kai chat/session client tests).
internal/kai/chat.go Deleted (removes Kai chat/session client).
internal/kai/agent_v1.yaml Deleted (removes Kai agent API spec).
internal/declarative/state/client_pagination_test.go Replaces local stringPtr/boolPtr helpers with new(...).
internal/declarative/resources/portal_identity_provider_test.go Replaces local pointer helper with new(...).
internal/declarative/resources/explain.go Uses slices.Contains and new(...) pointers; removes local boolPtr.
internal/declarative/resources/event_gateway_produce_policy.go Simplifies membership checks with slices.Contains.
internal/declarative/resources/event_gateway_consume_policy.go Simplifies membership checks with slices.Contains.
internal/declarative/planner/portal_child_test.go Replaces local generic ptr helper with new(...).
internal/declarative/planner/event_gateway_produce_policy_planner_test.go Removes local ptr helpers in favor of new(...).
internal/declarative/planner/event_gateway_consume_policy_planner.go Uses reflect.Value.Fields() iteration (Go 1.26).
internal/declarative/planner/env_placeholders.go Simplifies candidate checks with slices.Contains; updates pointer kind handling.
internal/declarative/loader/validator_test.go Replaces local stringPtr helper with new(...).
internal/declarative/loader/env_validation.go Uses reflect.TypeFor + Type.Fields() and reflect.Pointer (Go 1.26).
internal/declarative/loader/env_sources.go Uses reflect.TypeFor and reflect.Pointer (Go 1.26).
internal/declarative/executor/env.go Uses reflect.Pointer and reflect.TypeFor (Go 1.26).
internal/declarative/common/env_redaction.go Uses reflect.Pointer and reflect.TypeFor (Go 1.26).
internal/cmd/root/verbs/verbs.go Removes the Kai verb constant.
internal/cmd/root/verbs/kai/kai_test.go Deleted (removes Kai CLI tests).
internal/cmd/root/verbs/kai/kai.go Deleted (removes Kai CLI implementation).
internal/cmd/root/verbs/dump/declarative_children_test.go Replaces local ptr helpers with new(...).
internal/cmd/root/root.go Removes Kai command registration from root command initialization.
internal/cmd/root/products/konnect/eventgateway/produce-policies_test.go Replaces local ptr helpers with new(...).
internal/cmd/output/tableview/tableview.go Inlines markdown rendering via glamour to avoid internal/kai/render dependency.
go.sum Drops heredoc checksums no longer needed after Kai removal.
README.md Updates theme documentation wording/wrapping to remove Kai mention.

@rspurgeon
Copy link
Copy Markdown
Collaborator Author

cc @johnharris85 for visibility

@rspurgeon rspurgeon merged commit 68fbc7c into main Apr 25, 2026
26 checks passed
@rspurgeon rspurgeon deleted the gh-892-remove-kai branch April 25, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task: remove 'kai' subcommand

2 participants