Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the hidden/experimental kongctl kai subcommand and all supporting Kai implementation code, while keeping other interactive TUI features (notably kongctl view markdown previews) working independently of the removed Kai packages.
Changes:
- Removed Kai command registration (
verbs.Kai) and deleted theinternal/cmd/root/verbs/kaicommand implementation. - Deleted the entire
internal/kaiimplementation surface (API client, TUI, storage, rendering, specs, and tests). - Reworked markdown rendering in
tableviewto avoid depending oninternal/kai/render, plus minor Go 1.26 modernizations (e.g.,slices.Contains,reflect.TypeFor,reflect.Pointer,new(v)pointers).
Reviewed changes
Copilot reviewed 36 out of 38 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/konnect/helpers/portals.go | Switches pagination pointer fields to new(...) style pointers. |
| internal/konnect/helpers/api_versions.go | Updates pagination request fields to use new(...). |
| internal/konnect/helpers/api_publications.go | Updates pagination request fields to use new(...). |
| internal/konnect/helpers/api_implementations.go | Updates pagination request fields to use new(...). |
| internal/kai/tui/chat.go | Deleted (removes Kai interactive TUI). |
| internal/kai/tasks_test.go | Deleted (removes Kai task streaming tests). |
| internal/kai/tasks.go | Deleted (removes Kai tasks API client). |
| internal/kai/storage/storage_test.go | Deleted (removes Kai session storage tests). |
| internal/kai/storage/storage.go | Deleted (removes Kai session storage implementation). |
| internal/kai/render/render.go | Deleted (removes Kai markdown renderer wrapper). |
| internal/kai/logger.go | Deleted (removes Kai context logging helpers). |
| internal/kai/errors.go | Deleted (removes Kai transient error helpers). |
| internal/kai/chat_test.go | Deleted (removes Kai chat/session client tests). |
| internal/kai/chat.go | Deleted (removes Kai chat/session client). |
| internal/kai/agent_v1.yaml | Deleted (removes Kai agent API spec). |
| internal/declarative/state/client_pagination_test.go | Replaces local stringPtr/boolPtr helpers with new(...). |
| internal/declarative/resources/portal_identity_provider_test.go | Replaces local pointer helper with new(...). |
| internal/declarative/resources/explain.go | Uses slices.Contains and new(...) pointers; removes local boolPtr. |
| internal/declarative/resources/event_gateway_produce_policy.go | Simplifies membership checks with slices.Contains. |
| internal/declarative/resources/event_gateway_consume_policy.go | Simplifies membership checks with slices.Contains. |
| internal/declarative/planner/portal_child_test.go | Replaces local generic ptr helper with new(...). |
| internal/declarative/planner/event_gateway_produce_policy_planner_test.go | Removes local ptr helpers in favor of new(...). |
| internal/declarative/planner/event_gateway_consume_policy_planner.go | Uses reflect.Value.Fields() iteration (Go 1.26). |
| internal/declarative/planner/env_placeholders.go | Simplifies candidate checks with slices.Contains; updates pointer kind handling. |
| internal/declarative/loader/validator_test.go | Replaces local stringPtr helper with new(...). |
| internal/declarative/loader/env_validation.go | Uses reflect.TypeFor + Type.Fields() and reflect.Pointer (Go 1.26). |
| internal/declarative/loader/env_sources.go | Uses reflect.TypeFor and reflect.Pointer (Go 1.26). |
| internal/declarative/executor/env.go | Uses reflect.Pointer and reflect.TypeFor (Go 1.26). |
| internal/declarative/common/env_redaction.go | Uses reflect.Pointer and reflect.TypeFor (Go 1.26). |
| internal/cmd/root/verbs/verbs.go | Removes the Kai verb constant. |
| internal/cmd/root/verbs/kai/kai_test.go | Deleted (removes Kai CLI tests). |
| internal/cmd/root/verbs/kai/kai.go | Deleted (removes Kai CLI implementation). |
| internal/cmd/root/verbs/dump/declarative_children_test.go | Replaces local ptr helpers with new(...). |
| internal/cmd/root/root.go | Removes Kai command registration from root command initialization. |
| internal/cmd/root/products/konnect/eventgateway/produce-policies_test.go | Replaces local ptr helpers with new(...). |
| internal/cmd/output/tableview/tableview.go | Inlines markdown rendering via glamour to avoid internal/kai/render dependency. |
| go.sum | Drops heredoc checksums no longer needed after Kai removal. |
| README.md | Updates theme documentation wording/wrapping to remove Kai mention. |
Collaborator
Author
|
cc @johnharris85 for visibility |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kongctl kaicommand registration and the Kai command package.internal/kaiimplementation, tests, TUI, storage, rendering, and API spec files.go mod tidyand required Go 1.26 modernization cleanup.Validation
go fix ./...make formatmake buildmake lintmake testmake test-integrationgit grepconfirmed no remaining Kai command/package references.Closes #892