Fix: Preserve portal identity provider refs in dump output

[rspurgeon]

Summary

Fix portal identity provider dump round trips by preserving kongctl metadata during serialization.

• Add explicit JSON and YAML marshalers for PortalIdentityProviderResource so ref and portal are emitted alongside the embedded SDK identity provider payload.
• Add regression coverage for JSON/YAML serialization of portal identity provider metadata.
• Tighten the portal identity provider e2e scenario dump assertion to require the nested dumped provider ref.

Root Cause

PortalIdentityProviderResource embeds the SDK CreateIdentityProvider type, which has its own MarshalJSON. That promoted marshaler caused dump output to include SDK fields like type, enabled, and config, but drop kongctl metadata such as ref. Loading the dumped YAML then failed validation with an empty portal identity provider ref.

Validation

• go test ./internal/declarative/resources ./internal/cmd/root/verbs/dump
• make format
• make test
• make build
• make lint

The full portal identity provider e2e scenario was not run locally because it requires real IdP environment variables and resets the test organization.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Fixes portal identity provider dump/load round-trips by ensuring kongctl metadata (ref, portal) is preserved when serializing embedded SDK identity provider payloads.

Changes:

• Add custom JSON/YAML marshaling for PortalIdentityProviderResource to include ref/portal alongside SDK fields.
• Add regression tests for JSON + YAML dump output containing portal identity provider metadata.
• Tighten the portal IdP e2e scenario assertion to require the dumped nested provider ref.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
test/e2e/scenarios/portal/identity_providers/scenario.yaml	Strengthens scenario dump assertions to verify the provider ref is preserved.
internal/declarative/resources/portal_identity_provider_test.go	Adds regression coverage to ensure JSON/YAML serialization includes ref/portal.
internal/declarative/resources/portal_identity_provider.go	Introduces explicit marshalers to avoid embedded SDK MarshalJSON dropping kongctl metadata.