`pluginBinding` CRD #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mlavacca merged 12 commits into main from mlavacca/pluginbinding

Jul 26, 2024

Member

mlavacca commented Jul 25, 2024

This PR adds the pluginBinding CRD to the configuration.konghq.com API group.

mlavacca force-pushed the mlavacca/pluginbinding branch from 03891e3 to 395dd97 Compare

July 25, 2024 08:47

mlavacca requested a review from pmalek

July 25, 2024 08:48

pmalek reviewed

View reviewed changes

api/configuration/v1alpha1/kongpluginbinding_types.go Outdated Show resolved Hide resolved

api/configuration/v1alpha1/kongpluginbinding_types.go Outdated Show resolved Hide resolved

api/configuration/v1alpha1/kongpluginbinding_types.go Outdated Show resolved Hide resolved

api/configuration/v1alpha1/kongpluginbinding_types.go Outdated Show resolved Hide resolved

api/configuration/v1alpha1/kongpluginbinding_types.go Show resolved Hide resolved

api/configuration/v1alpha1/kongpluginbinding_types.go Outdated Show resolved Hide resolved

api/configuration/v1alpha1/kongpluginbinding_types.go Outdated Show resolved Hide resolved

api/configuration/v1alpha1/kongpluginbinding_types.go Outdated Show resolved Hide resolved

pmalek force-pushed the main branch from 1b1b548 to 62dab91 Compare

July 25, 2024 11:04

Member

pmalek commented Jul 25, 2024 •

edited

Loading

Please rebase on top of main (62dab91) to include the CI that tests the generate CRDs and also the samples from config/samples.

If possible I suggest to add samples for this CRD to verify that all validations and CEL that's added works.

pmalek force-pushed the main branch from 570224d to 991ca69 Compare

July 25, 2024 11:23

This was referenced Jul 25, 2024

How to configure KongPluginBindings to be global #7

Closed

Allow PluginBindings to be used on Kubernetes CRDs for Gateway Configuration #8

Closed


          feat: KongPluginBinding CRD

86b370f

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>

mlavacca force-pushed the mlavacca/pluginbinding branch from 395dd97 to 2503961 Compare

July 25, 2024 12:56

mlavacca added 2 commits

July 25, 2024 14:57


          Removed additional printcolumns

83667d8

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>


          added docs and issues links

8ccec01

- added documentation to the `.spec.kong` field
- added a link to a TODO GH issue to the `.spec.kong` field
- added a link to a TODO GH issue to the `.spec.entityRef` field

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>

mlavacca force-pushed the mlavacca/pluginbinding branch from 2503961 to 8ccec01 Compare

July 25, 2024 12:58

mlavacca added 2 commits

July 25, 2024 14:59


          remove leftovers

53b6398

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>


          commented out GenericEntityRef

17dfeeb

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>

mlavacca force-pushed the mlavacca/pluginbinding branch from bd0d1e7 to 17dfeeb Compare

July 25, 2024 13:09

mlavacca added 2 commits

July 25, 2024 15:10


          added issue link on RefGrants

da37fe0

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>


          feat: added cel to pluginbinding kong field

aa710cf

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>

mlavacca mentioned this pull request

Test CEL rules on CRDs #10

Closed

1 task

Member Author

mlavacca commented Jul 25, 2024

Please rebase on top of main (62dab91) to include the CI that tests the generate CRDs and also the samples from config/samples.

If possible I suggest to add samples for this CRD to verify that all validations and CEL that's added works.

I've added an exemplar manifest, but I think we should have a slightly more complex test suite. I opened #10 for this, let me know if it makes sense to you.

mlavacca force-pushed the mlavacca/pluginbinding branch 2 times, most recently from b6154fe to d628be3 Compare

July 25, 2024 14:12


          added kongpluginbinding sample

a5f0e51

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>

mlavacca force-pushed the mlavacca/pluginbinding branch from d628be3 to a5f0e51 Compare

July 25, 2024 14:12


          kongpluginbindings added to kustomize

fad6cb8

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>

mlavacca requested a review from pmalek

July 25, 2024 14:21

pmalek reviewed

View reviewed changes

api/configuration/v1alpha1/kongpluginbinding_types.go Outdated Show resolved Hide resolved

pmalek reviewed

View reviewed changes

api/configuration/v1alpha1/kongpluginbinding_types.go Outdated Show resolved Hide resolved


          chore: changed kong field comment

b705337

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>

mlavacca force-pushed the mlavacca/pluginbinding branch from 39f6db5 to b705337 Compare

July 26, 2024 08:20

mlavacca requested a review from pmalek

July 26, 2024 08:20


          chore: leftover comment removed

6b66e90

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>

mlavacca force-pushed the mlavacca/pluginbinding branch from 84ed5cb to 6b66e90 Compare

July 26, 2024 08:26

pmalek approved these changes

View reviewed changes

api/configuration/v1alpha1/kongpluginbinding_types.go Outdated Show resolved Hide resolved


          chore: changed CEL validation message

335524d

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>

mlavacca enabled auto-merge (squash)

July 26, 2024 12:27

pmalek approved these changes

View reviewed changes

mlavacca merged commit c10e829 into main

mlavacca deleted the mlavacca/pluginbinding branch

July 26, 2024 12:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet