Update a few more libraries#345
Merged
Konloch merged 5 commits intoKonloch:masterfrom Aug 23, 2021
Merged
Conversation
This should fix multidexed APK files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Updating these libraries in the future is so much easier when we update them step by step and eliminating new bugs after each commit. JADX will be ever-changing until its next release and we should ensure that everything will be working once it is available.
That's why I chose jitpack to build most libraries now. JD-GUI and APKTool needed many internal modifications (mainly exclusions), which is why I will take a look at them in a separate PR (not today and most likely also not within the next week).
My fork of Dex2Jar now also supports building via Jitpack and I forked FernFlower and made some small modifications such that it is also now available via Jitpack. This allows for much easier updating and maintaining of these libraries.