Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Suggestion : move to a match statement for _check_shader_visibility() #24

@Loufe

Description

@Loufe

In my cleanup PR earlier in the year, I didn't spend the time to look into why it was setup as such, but reviewing an issue just right now made me wonder if we can improve this:
image

A couple notes:

  • If the full string text never changes, we should move away using start_with() as it's a performance drag vs a simple full string compare. The only reason not to would be that we have multiple instances of the nodes so the names are appended with random identifiers. In this case, let's use a different approach than .name, like a unique_ID or uniquename.
  • If we can remove the starts_with(), we should switch to a match function as well for readability. The compiler probably makes them equivalent, but it's poor practice.
  • The entire function is indented one level too many, should be fixed.

I can do this in 10 or so days when I'm back from my business trip if nobody takes it upon themselves.


On a side note, @ItsKorin, I don't mind sharing the maintenance burden for the plugin with you (as best I can) if you want to trust me with maintainer privileges. Feel free to reach out to discuss further.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions