This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Dynamic Shader Updates from code #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added functionality: - Smooth transitions between previous and future effect states (ex: 0 blur slowly rising to 100)
Always errors because get_children() gets unintended child nodes.
Added demo code on smooth transitions. + TLC
SAED2906
commented
Apr 16, 2024
| if _name.begins_with("CRT"): | ||
| return true if configuration.CRT else false | ||
|
|
||
| # get_children() returning all _names leading Always to: |
Contributor
Author
There was a problem hiding this comment.
The error is being triggered every reload due to the get_children() method returning more than expected.
Owner
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an example of how code can dynamically change the shaders applied to objects without the user code needing to manually set reload to true.
I'm trying to find a way to fade out the need for a reload bool to make it completely dynamic.