Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Conversation

@Loufe
Copy link
Contributor

@Loufe Loufe commented Apr 30, 2024

Hi Korin,

In my project I dynamically add an entire instance of a postprocessingconfig resource to the node dynamically, so I figured it would be more efficient to make the "update shaders" function by default public, so I could call it instead of flipping the toggle to force update.

Looking at @SAED2906 's addition of set functions, I added a by-default TRUE variable to the main node to enable/disable loading these values dynamically. The "enter scene tree" call to the function isn't touched so disabling this code shouldn't impact loading. Hope this is an OK compromise for you both. If not, happy to remove it, as it doesn't change anything in my project.

The chromatic abberation filter was also the only one that wasn't hidden by default which is important doing things the way I have as the absence of any config (I think) should default to any config being applied, the chromatic abberation was the only one which had that default visibility.

I also removed the positive is_editor_hint() case as mentioned in my issue #12 but am open if there's something I missed here.

Thanks guys.

@zaknafean
Copy link

Just another end user, but your changes are definitely helpful. I actually couldn't get screen shake to work at all without manually calling update(), so marking it non private certainly makes sense to me.

@KorinDev KorinDev merged commit ee72c92 into KorinDev:main May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants