This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Make dynamic update calls work and small bugfix #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Korin,
In my project I dynamically add an entire instance of a postprocessingconfig resource to the node dynamically, so I figured it would be more efficient to make the "update shaders" function by default public, so I could call it instead of flipping the toggle to force update.
Looking at @SAED2906 's addition of set functions, I added a by-default TRUE variable to the main node to enable/disable loading these values dynamically. The "enter scene tree" call to the function isn't touched so disabling this code shouldn't impact loading. Hope this is an OK compromise for you both. If not, happy to remove it, as it doesn't change anything in my project.
The chromatic abberation filter was also the only one that wasn't hidden by default which is important doing things the way I have as the absence of any config (I think) should default to any config being applied, the chromatic abberation was the only one which had that default visibility.
I also removed the positive is_editor_hint() case as mentioned in my issue #12 but am open if there's something I missed here.
Thanks guys.