[pull] main from chroma-core:main#116
Merged
pull[bot] merged 5 commits intoKornaAI:mainfrom Mar 7, 2025
Merged
Conversation
## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - The Dockerfile in rust/cli was incorrectly overwritten to use distributed config. This dockerfile should be for single node config only - I moved our helm to a local command so that we can call `set-file` this also mirrors what we do in hosted chroma - Removed the test namespace, as its duplicated with the one in the main chart - Turned off reset by default, and used values.dev to override it - Consolidate postgres into the same section of other test components in tiltfile for cleanliness - Use configmap for rust-frontend-service config, mirror'ing what we do in other envs - New functionality - None ## Test plan *How are these changes tested?* Manually tested tilt - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes *Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs repository](https://github.com/chroma-core/docs)?* --------- Co-authored-by: Sicheng Pan <sicheng@trychroma.com>
## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Rust frontend service service account so we can attach roles to it in eks in hosted chroma - New functionality - None ## Test plan *How are these changes tested?* They are not! - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes None
## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Bind SA from last pr to RFE (#3924) - New functionality - None ## Test plan *How are these changes tested?* - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes None
## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Appends the quota overrage error struct in the error string - New functionality - ... ## Test plan *How are these changes tested?* - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )