Skip to content

Some bug fixes#266

Merged
KosherJava merged 4 commits into
KosherJava:3-0-modernizationfrom
dickermoshe:patch-5
Apr 30, 2026
Merged

Some bug fixes#266
KosherJava merged 4 commits into
KosherJava:3-0-modernizationfrom
dickermoshe:patch-5

Conversation

@dickermoshe
Copy link
Copy Markdown
Contributor

@dickermoshe dickermoshe commented Apr 30, 2026

  1. Africa/Khartoum that had a transition from 11:59:59 to 13:00:00 on Jan 15, 2000. Previously, we would return the incorrect time because we were creating a ZonedDateTime for 12:00 and then adding n hours to it. However, THERE IS NO 12:00 on Jan 15, 2000. Java automatically bumps the ZonedDateTime to 13:00. Chatzos is returned an hour later than it should.
Failing Test Case

TestCase {
        year: 2000,
        month: 1,
        day: 15,
        latitude: 21.743167270756928,
        longitude: 27.55334330024661,
        elevation: 486.715389268106,
        timezone: "Africa/Khartoum",
        preset_name: "getFixedLocalChatzos",
        ateret_torah_sunset_offset_minutes: 23,
        candle_lighting_offset_minutes: 36,
        use_astronomical_chatzos_for_other_zmanim: false,
        use_elevation: false,
}

  1. Previously, going back a single month from AdarII would skip AdarI and go directly to Sivan.
  2. Added a single iteration to improve noon accuracy

@KosherJava KosherJava merged commit f073b0c into KosherJava:3-0-modernization Apr 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants