[codex] Fix mmseqs2 TrueMultimer custom template support#607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes
create_individual_features.pyso TrueMultimer custom template databases are forwarded into themmseqs2feature-generation path.Closes #332.
Root cause
TrueMultimer already creates a local custom template database, but the
mmseqs2branch dropped that path and always called ColabFold withcustom_template_path=None. As a result, multimeric templates were ignored whenever--use_mmseqs2was enabled.What changed
custom_template_pathplumbing tocreate_and_save_monomer_objects()make_mmseq_features()MonomericObject.make_mmseq_features()to forwardcustom_template_pathto ColabFoldcreate_individual_features.pyandobjects.pycode pathsValidation
pytest -q test/integration/test_create_individual_features.py -k 'mmseqs or process_multimeric_features or create_and_save_monomer_objects'pytest -q test/unit/test_objects.py -k 'mmseq_features'pytest -q test/unit/test_mmseqs_species_identifiers.pypytest -q test/integration/test_create_individual_features.py