Optin experimental Instant in codegen if this type is used #1601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreiKingsley
approved these changes
Dec 3, 2025
Jolanrensen
reviewed
Dec 3, 2025
| } | ||
|
|
||
| @Test | ||
| fun `opt in experimental Instant`() { |
Collaborator
There was a problem hiding this comment.
This test seems to pass, even without the fix. The errors are only logged to console
Collaborator
Author
There was a problem hiding this comment.
Yes, no idea how to make it fail though. I made sure to check that with my fix logger output has no errors
Collaborator
Author
There was a problem hiding this comment.
Ideally we just need to revert this fix in the next release when it's no longer experimental
Jolanrensen
added a commit
that referenced
this pull request
Dec 3, 2025
Jolanrensen
added a commit
that referenced
this pull request
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.