Skip to content

Add missed OverloadAccessApi deprecations in all.kt, cols.kt#1697

Merged
koperagen merged 3 commits intomasterfrom
add-missed-deprecations
Feb 20, 2026
Merged

Add missed OverloadAccessApi deprecations in all.kt, cols.kt#1697
koperagen merged 3 commits intomasterfrom
add-missed-deprecations

Conversation

@koperagen
Copy link
Copy Markdown
Collaborator

@koperagen koperagen commented Feb 18, 2026

Interesting that i also deprecate some of the APIs we have compiler support for:

AllAfter0
Cols0
AllBefore2

df.select { cols(a, b) }, df.select { allAfter(b) } and df.select { allBefore(b) }

They're generally nice and useful, aren't they? Let's have one round of "undeprecation" some time later and decide what ColumnReference APIs we'd like to keep #1698

@koperagen koperagen added this to the 1.0.0-Beta5 milestone Feb 18, 2026
@koperagen koperagen self-assigned this Feb 18, 2026
@koperagen koperagen added the API If it touches our API label Feb 18, 2026
@Jolanrensen
Copy link
Copy Markdown
Collaborator

Jolanrensen commented Feb 18, 2026

They're generally nice and useful, aren't they? Let's have one round of "undeprecation" some time later and decide what ColumnReference APIs we'd like to keep #1698

Honestly, I'm not sure I feel comfortable having any Beta release with cols(a, b) being deprecated. I use it Often (with a capital O!). Especially to avoid long and chains.

df.select { cols(a, b, c, d, e) }

is waaaay more readable and typable than

df.select { a and b and c and d and e }

(I mean, there's a reason we have commas in our own language, no? ;P)

If we do the undecprecation cycle before beta5, I'm fine with this, but otherwise I don't think it's a good idea to deprecate it, even if temporarily.

Having all KProperties overloads deprecated is an earlier oversight by us of course :)

@koperagen
Copy link
Copy Markdown
Collaborator Author

ok, in this case let me update the PR. But i suspect we still might need undeprecation cycle

@koperagen
Copy link
Copy Markdown
Collaborator Author

koperagen commented Feb 18, 2026

Check last commit - looks like we have a lot of cases where in CS DSL we actually need to keep ColumnRefernce overload. Different story from top level APIs, right?

@koperagen koperagen merged commit 8e4cffc into master Feb 20, 2026
5 checks passed
@koperagen koperagen deleted the add-missed-deprecations branch March 9, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API If it touches our API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants