importDataSchema() notebooks fix#1714
Merged
Jolanrensen merged 1 commit intomasterfrom Mar 10, 2026
Merged
Conversation
…. Improved error message for importDataSchema() in notebooks. Removed unused `importDataSchema: String`
Jolanrensen
added
bug
koperagen
reviewed
Feb 26, 2026
| is CodeGenerationReadResult.Error -> { | ||
| execute( | ||
| """DISPLAY("Failed to read data schema from ${importDataSchema.url}: ${codeGenResult.reason}")""", | ||
| display( |
Collaborator
There was a problem hiding this comment.
Can you please attach a screenshot?
Collaborator
There was a problem hiding this comment.
Looks good!
Maybe remove SupportedCodeGenerationFormat interface from Jdbc while it's not implemented? Available formats: ... looks misleading
Collaborator
Author
There was a problem hiding this comment.
hmm, that might be an idea. @zaleslaw Are you okay with this? It's not possible to generate dataschema interfaces for JDBC without KSP/gradle after all, right? (also in notebooks, it's not possible to generate just types for jdbc, right?)
koperagen
reviewed
Feb 26, 2026
Collaborator
Author
Collaborator
|
@Jolanrensen, I agree with the proposed way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1570
Made unsupported functions in
Jdbcthrow exceptions instead of errors. Improved error message forimportDataSchema()in notebooks. Removed unusedimportDataSchema: String