Skip to content

Parsing/convert docs update#1817

Merged
Jolanrensen merged 5 commits intomasterfrom
parse-convert-docs-update
Apr 28, 2026
Merged

Parsing/convert docs update#1817
Jolanrensen merged 5 commits intomasterfrom
parse-convert-docs-update

Conversation

@Jolanrensen
Copy link
Copy Markdown
Collaborator

@Jolanrensen Jolanrensen commented Apr 21, 2026

Fixes #1798

Updates docs for parse and convert.

Changes explainer DF render logic so more examples can be shown.

Should be reviewed per-commit :)

Should be released close to beta 5 release to provide up-to-date information

@Jolanrensen Jolanrensen added this to the 1.0.0-Beta6 milestone Apr 21, 2026
@Jolanrensen Jolanrensen added the documentation Improvements or additions to documentation (not KDocs) label Apr 21, 2026
@Jolanrensen Jolanrensen force-pushed the parse-convert-docs-update branch 8 times, most recently from adae8fc to f6ff760 Compare April 23, 2026 10:34
@Jolanrensen Jolanrensen marked this pull request as ready for review April 23, 2026 11:30
@koperagen
Copy link
Copy Markdown
Collaborator

Changes explainer DF render logic so more examples can be shown.

Share a screenshot please

"expression is too long ${it.length}. better to split sample in multiple snippets",
)
expressions.joinToString(".") { it.source }.let {
if (it.length > 50) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it a bit too short for a cut off?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll increase it :) It's just that 90 was way too long on smaller screens

<br>
<details>
<summary>df.pivot { city }.groupBy { name }.default(0).min()</summary>
<summary>df.pivot { city }.groupBy { name }.default(0).min(...</summary>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=((

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if only for this example, I'll increase the limit hahaha

@Jolanrensen
Copy link
Copy Markdown
Collaborator Author

Changes explainer DF render logic so more examples can be shown.

Share a screenshot please

Well, for instance, this large example now works

image

Copy link
Copy Markdown
Collaborator

@koperagen koperagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Jolanrensen Jolanrensen force-pushed the parse-convert-docs-update branch from 5ce1cad to 9785871 Compare April 28, 2026 11:13
@Jolanrensen Jolanrensen merged commit d1b0ad0 into master Apr 28, 2026
4 of 5 checks passed
@Jolanrensen Jolanrensen deleted the parse-convert-docs-update branch April 28, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation (not KDocs)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parse date-time and convert docs need to be updated

2 participants