Fixed shapefile read from remote url#1820
Merged
AndreiKingsley merged 2 commits intomasterfrom Apr 21, 2026
Merged
Conversation
koperagen
approved these changes
Apr 21, 2026
Jolanrensen
reviewed
Apr 21, 2026
| url | ||
| } else { | ||
| val dirName = urlPath.substringAfterLast('/') | ||
| URI("${url.toString().trimEnd('/')}/$dirName.shp").toURL() |
Collaborator
There was a problem hiding this comment.
so... if the user supplies another url, something like "/path/to/shapeFile.zip", we will get "shapeFile.zip.shp" and break? I would write it a bit safer with a helpful exception message
Collaborator
Author
There was a problem hiding this comment.
I just followed Nikita's logic; we should research usecases and improve it in the future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.