Skip to content

Conversation

@Kordyjan
Copy link
Contributor

@Kordyjan Kordyjan commented Apr 19, 2018

I added support for Kotlin 1.2.40.
Teamcity configuration was moved out of repository.
Few minor bugs were fixed.

@zarechenskiy
Copy link
Contributor

In future I recommend to divide such commits like Update to Kotlin 1.2.40 version into two, one will increase compiler version, other will increase plugin version, this way it will be easier to review

Copy link
Contributor

@zarechenskiy zarechenskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix version for maven and I'll merge this PR, thank you!

<groupId>kotlin.eclipse</groupId>
<artifactId>kotlin.eclipse.plugin</artifactId>
<version>0.8.3-SNAPSHOT</version>
<version>0.8.4-SNAPSHOT</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, don't forget to increase version for maven, see https://github.com/JetBrains/kotlin-eclipse/blob/master/pom.xml#L31
It seems that for now there should be version 1.2.40-eap-62 (because 1.2.40 isn't released yet)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@zarechenskiy zarechenskiy merged commit 0109bcd into Kotlin:master Apr 19, 2018
gayanper pushed a commit to gayanper/kotlin-eclipse that referenced this pull request Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants