Replace stat call with NSFileManager API on Apple target #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting from May 1, 2024 developers have to explicitly declare why they use APIs allowing to access file timestamps in a privacy manifest files; otherwise an app won't be accepted by the AppStore. The only restricted API we're currently using is stat, and since we don't extract any timestamps using it, we can safely replace it with NSFileManager::fileAttributesAtPath. For more details on the restriction imposed on timestamp-accessing APIs read https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api Closes #297
shanshin
approved these changes
Apr 22, 2024
| } | ||
|
|
||
| internal actual fun metadataOrNullImpl(path: Path): FileMetadata? { | ||
| val attributes = NSFileManager.defaultManager().fileAttributesAtPath(path.path, traverseLink = true) ?: return null |
Contributor
There was a problem hiding this comment.
Is invoking NSFileManager.defaultManager() is a cheap operation?
Can we lazily cache default manager?
Collaborator
Author
There was a problem hiding this comment.
It's just a getter: https://github.com/apple/swift-corelibs-foundation/blob/77af9c5a984f40e186c0ba127cff88f2a2588c15/Sources/Foundation/FileManager.swift#L43
Not sure if we can gain much by caching it
| * Copyright 2010-2023 JetBrains s.r.o. and Kotlin Programming Language contributors. | ||
| * Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE.txt file. | ||
| */ | ||
|
|
Contributor
There was a problem hiding this comment.
No special Gradle configuring for the new source set?
Collaborator
Author
There was a problem hiding this comment.
It's the old one:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from May 1, 2024 developers have to explicitly declare why they use APIs allowing to access file timestamps in privacy manifest files; otherwise, an app won't be accepted by the AppStore.
The only restricted API we're currently using is stat, and since we don't extract any timestamps using it, we can safely replace it with NSFileManager::fileAttributesAtPath.
For more details on the restriction imposed on timestamp-accessing APIs read https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api
Closes #297