Propagate byte read/write counts from unsafe buffer ops #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the caller to more easily perform their own bookkeeping based on the amount of bytes moved.
fzhinkin
requested changes
Aug 12, 2024
Collaborator
fzhinkin
left a comment
fzhinkin
left a comment
There was a problem hiding this comment.
The change itself looks good, but I think we should also update JVM-specific extensions.
For readFromHead and writeToTail the change should be trivial as they delegate to common functions.
For readBulk it should be trivial too, we just have to use Long instead of Int there.
Contributor
Author
|
Indeed. Done. |
Collaborator
|
@e5l FYI: formally, that's a breaking change, but Ktor (the only user of the API published on GH) should be unaffected since updated functions are all inline functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the caller to more easily perform their own bookkeeping based on the amount of bytes moved.
Closes #360