Skip to content

Allow digestLength of 0#36

Merged
05nelsonm merged 1 commit intomasterfrom
issue/30-digest-length-0
Apr 13, 2023
Merged

Allow digestLength of 0#36
05nelsonm merged 1 commit intomasterfrom
issue/30-digest-length-0

Conversation

@05nelsonm
Copy link
Copy Markdown
Member

Closes #30

This PR alters Digest constructor argument checks to allow passing a digestLength of 0. Previously, anything less than 1 would throw an IllegalArgumentException (because wtf is the point, right?). 0 is now an acceptable length for digest() output.

@05nelsonm 05nelsonm self-assigned this Apr 13, 2023
Copy link
Copy Markdown
Member Author

@05nelsonm 05nelsonm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@05nelsonm 05nelsonm merged commit 21c306c into master Apr 13, 2023
@05nelsonm 05nelsonm deleted the issue/30-digest-length-0 branch April 13, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

digestLength should accept 0 as argument

1 participant