Preload access rights from file#2009
Merged
pbiering merged 3 commits intoKozea:masterfrom Mar 2, 2026
Merged
Conversation
Contributor
Author
|
Working on mypy... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configparser is quite slow and can slow down
from_fileaccess rights on large collections.For instance on my lab with 100,000 accounts, a
PROPFINDon/lasts (with #2002 already integrated):from_filesowner_onlyThe proposed patch extracts configparser settings during
__init__()and stores them in a dict. In the same lab, thePROPFINDrequests last 15 seconds, which is nearly as good asowner_only.Note : I also tried to pre-compile regexps but this did not yield a visible performance improvement, configparser really seems to be the bottleneck here.