Skip to content

Preload access rights from file#2009

Merged
pbiering merged 3 commits intoKozea:masterfrom
flesueur:master
Mar 2, 2026
Merged

Preload access rights from file#2009
pbiering merged 3 commits intoKozea:masterfrom
flesueur:master

Conversation

@flesueur
Copy link
Contributor

@flesueur flesueur commented Mar 2, 2026

configparser is quite slow and can slow down from_file access rights on large collections.

For instance on my lab with 100,000 accounts, a PROPFIND on / lasts (with #2002 already integrated):

  • 22 seconds with from_files
  • 13 seconds with owner_only

The proposed patch extracts configparser settings during __init__() and stores them in a dict. In the same lab, the PROPFIND requests last 15 seconds, which is nearly as good as owner_only.

Note : I also tried to pre-compile regexps but this did not yield a visible performance improvement, configparser really seems to be the bottleneck here.

@flesueur
Copy link
Contributor Author

flesueur commented Mar 2, 2026

Working on mypy...

@pbiering pbiering added this to the 3.7.0 milestone Mar 2, 2026
Copy link
Collaborator

@pbiering pbiering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@pbiering pbiering merged commit d25e745 into Kozea:master Mar 2, 2026
28 checks passed
pbiering added a commit that referenced this pull request Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants