Remove test from setup.py, unify test requirements#565
Merged
glepretre merged 3 commits intoKozea:masterfrom Aug 12, 2024
Merged
Remove test from setup.py, unify test requirements#565glepretre merged 3 commits intoKozea:masterfrom
glepretre merged 3 commits intoKozea:masterfrom
Conversation
akx
force-pushed
the
setup-py-test
branch
3 times, most recently
from
51d5f9b to
75d147f
Compare
glepretre
reviewed
Jul 29, 2024
Contributor
glepretre
left a comment
glepretre
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I have a question about the type-comparison ignored.
And I would like another opinion about the test class removal.
For your information, the setuptools version has been yanked: pypa/setuptools#4519 (comment)
Co-authored-by: Christian Clauss <cclauss@me.com>
glepretre
approved these changes
Aug 12, 2024
Contributor
glepretre
left a comment
glepretre
left a comment
There was a problem hiding this comment.
LGTM
What's the release process @gentooboontoo ?
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See pypa/setuptools#931 –
setuptools>=72removes the test module.I also noticed
toxspecified different test requirements thansetup.py.