Skip to content

feat: add generic gh action#12

Merged
leo-dur merged 1 commit intomasterfrom
story/add-generic-github-action
Dec 2, 2021
Merged

feat: add generic gh action#12
leo-dur merged 1 commit intomasterfrom
story/add-generic-github-action

Conversation

@leo-dur
Copy link
Copy Markdown
Contributor

@leo-dur leo-dur commented Nov 30, 2021

Add a generic composite action to run pre-commit from the CI.

It's a replacement for https://github.com/pre-commit/action because:

  • it's a deprecated action
  • it restores the cache for each hook-stage
  • painful to use with hooks of type commit-msg

Note1: Might be better to put this action in its own repo.
Note2: The action is deprecated because they are pushing for their own CI (which cames with its own cons)

Ex of usage: https://github.com/Kpler/ct-webserver/pull/1894

image

@leo-dur leo-dur self-assigned this Nov 30, 2021
@leo-dur leo-dur force-pushed the story/add-generic-github-action branch 5 times, most recently from f75ff12 to 6731138 Compare November 30, 2021 03:56
Copy link
Copy Markdown
Contributor

@gregoirechauvet gregoirechauvet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks quite nice!

Comment thread action.yml Outdated
@leo-dur leo-dur force-pushed the story/add-generic-github-action branch 2 times, most recently from 4418f9d to ccd2f5c Compare December 2, 2021 03:41
@leo-dur leo-dur changed the title chore: add generic gh action feat: add generic gh action Dec 2, 2021
@leo-dur leo-dur force-pushed the story/add-generic-github-action branch from ccd2f5c to bf3a567 Compare December 2, 2021 03:42
@leo-dur leo-dur marked this pull request as ready for review December 2, 2021 03:44
@leo-dur leo-dur merged commit 877530b into master Dec 2, 2021
@leo-dur leo-dur deleted the story/add-generic-github-action branch December 2, 2021 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants