Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds comprehensive unit tests for the
auth,account, andcertpackages, significantly improving test coverage for authentication, account management, and certificate issuance/submission flows. The new tests cover successful cases, error handling, and edge conditions, ensuring robustness for key CLI features.Authentication and Account Management Tests:
auth, including verification of config file updates and error handling for authentication failures.Certificate Issuance and Submission Tests:
RunIssue) with and without waiting for issuance, including file output checks, permission validation, auto-renewal, default filename logic, and invalid key type handling.RunSubmit) covering CSR reading, wait mode, file-not-found errors, auto-renewal, and issuance failure handling.