Skip to content

fix: justification fix, beam offset calc fixes, ifc and glb export fixes and more#182

Merged
Krande merged 34 commits intoKrande:mainfrom
oleandor:fix/justification_and_more
Apr 8, 2026
Merged

fix: justification fix, beam offset calc fixes, ifc and glb export fixes and more#182
Krande merged 34 commits intoKrande:mainfrom
oleandor:fix/justification_and_more

Conversation

@oleandor
Copy link
Copy Markdown
Contributor

@oleandor oleandor commented Mar 4, 2026

No description provided.

@oleandor
Copy link
Copy Markdown
Contributor Author

oleandor commented Mar 5, 2026

@Krande, please have a look when you find the time. test_write_step seems to fail, and i sort of understand why, not sure what is the best way to handle it. we could set the section made by outer_poly to general section, and then try to calc the Cgy, Cgz ect, - or we can just bypass it in curve_offset_local. not sure how much this outer_poly defiend section is used

@Krande
Copy link
Copy Markdown
Owner

Krande commented Mar 11, 2026

Hey, sorry for slow response. Thanks for this PR! Will try to take a look this week or the next:)

@oleandor
Copy link
Copy Markdown
Contributor Author

oleandor commented Mar 16, 2026

I think I’ve solved it now. The COG calculation should now be consistent with the ADA model definition, GXML export/import, FEM import, beam justifications, visualizations in the ADA viewer, as well as IFC and GLB exports.

I’ve also updated the Para model based on this PR, so hopefully you’re happy with the changes and we can release the Para model with this dependency update. 🙂

…or ada viewer / glb. the reason was due to is_identity() inconsistency due to cache implementation issue
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2026

👋 Hi there! I have checked your PR and found no issues. Thanks for your contribution!

PR Review:

I found no pr-related issues.

  • ✅ PR title is ok
  • ✅ Release label is ok
  • ✅ SOURCE_KEY is set as a secret
  • ✅ Skipping release

Python Review:

I found no python-related issues.

Python Linting results:

  • ✅ Isort
  • ✅ Black
  • ✅ Ruff

Python Packaging results:

  • ✅ I found the PYPI_API_TOKEN secret.
Packaging Type Package Name Version
pyproject.toml ada-py 0.7.11
pypi ada-py 0.7.11

@Krande
Copy link
Copy Markdown
Owner

Krande commented Apr 8, 2026

@oleandor Thanks a lot for your contribution! I made some minor cosmetic changes, but all in all I think this looks good!

@Krande Krande merged commit caaf186 into Krande:main Apr 8, 2026
20 checks passed
@Krande Krande linked an issue Apr 8, 2026 that may be closed by this pull request
@oleandor
Copy link
Copy Markdown
Contributor Author

oleandor commented Apr 9, 2026

Thank you! I see that it was merged with label release-skip. I will create a new PR with another unrelated fix, but maybe we can bump the version as part of that PR?

@Krande
Copy link
Copy Markdown
Owner

Krande commented Apr 9, 2026

Thank you! I see that it was merged with label release-skip. I will create a new PR with another unrelated fix, but maybe we can bump the version as part of that PR?

Ah, yes that was my bad. Yes, we'll bump the version on your next PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Beam justification

2 participants