Skip to content

Hotfix fsi submodelparts#815

Merged
jginternational merged 5 commits intomasterfrom
hotfix-fsi-submodelparts
Jun 16, 2021
Merged

Hotfix fsi submodelparts#815
jginternational merged 5 commits intomasterfrom
hotfix-fsi-submodelparts

Conversation

@jginternational
Copy link
Copy Markdown
Member

@jginternational jginternational commented Jun 14, 2021

Implements #814

@jginternational jginternational self-assigned this Jun 14, 2021
@jginternational jginternational linked an issue Jun 14, 2021 that may be closed by this pull request
@jginternational jginternational marked this pull request as ready for review June 14, 2021 15:56
@jginternational
Copy link
Copy Markdown
Member Author

@rubenzorrilla You can see that also python functions are fixed by using intervals

@jginternational
Copy link
Copy Markdown
Member Author

MOK 3D still fails:

Traceback (most recent call last):
  File "C:\Users\garat\Desktop\aaa.gid\MainKratos.py", line 35, in <module>
    simulation.Run()
  File "E:\Deploy_Kratos\KratosMultiphysics\analysis_stage.py", line 47, in Run
    self.Initialize()
  File "C:\Users\garat\Desktop\aaa.gid\MainKratos.py", line 16, in Initialize
    super().Initialize()
  File "E:\Deploy_Kratos\KratosMultiphysics\FSIApplication\fsi_analysis.py", line 23, in Initialize
    self._GetSolver().PrepareModelPart()
  File "E:\Deploy_Kratos\KratosMultiphysics\FSIApplication\partitioned_fsi_base_solver.py", line 128, in PrepareModelPart
    self._GetFSICouplingInterfaceStructure().GetInterfaceModelPart()
  File "E:\Deploy_Kratos\KratosMultiphysics\FSIApplication\fsi_coupling_interface.py", line 92, in GetInterfaceModelPart
    self._fsi_interface_model_part = self._create_fsi_interface_model_part()
  File "E:\Deploy_Kratos\KratosMultiphysics\FSIApplication\fsi_coupling_interface.py", line 321, in _create_fsi_interface_model_part
    self._get_partitioned_fsi_utilities().CreateCouplingSkin(
RuntimeError: Error: Invalid points number. Expected 3, given 4




in kratos/geometries/triangle_3d_3.h:242:Triangle3D3<class Node<3,class Dof > >::Triangle3D3
   kratos/conditions/mesh_condition.cpp:96:MeshCondition::Create
   kratos/sources/model_part.cpp:1489:ModelPart::CreateNewCondition
   kratos/sources/model_part.cpp:1460:ModelPart::CreateNewCondition

mok3Dfails.gid.zip

@rubenzorrilla
Copy link
Copy Markdown
Member

@rubenzorrilla You can see that also python functions are fixed by using intervals

I see, as a temporary solution I'm locally doing this. The point is that there is an ongoing PR that should make possible to keep the current syntax (this is why I wanted to keep them as they are).

@rubenzorrilla
Copy link
Copy Markdown
Member

MOK 3D still fails:

Traceback (most recent call last):
  File "C:\Users\garat\Desktop\aaa.gid\MainKratos.py", line 35, in <module>
    simulation.Run()
  File "E:\Deploy_Kratos\KratosMultiphysics\analysis_stage.py", line 47, in Run
    self.Initialize()
  File "C:\Users\garat\Desktop\aaa.gid\MainKratos.py", line 16, in Initialize
    super().Initialize()
  File "E:\Deploy_Kratos\KratosMultiphysics\FSIApplication\fsi_analysis.py", line 23, in Initialize
    self._GetSolver().PrepareModelPart()
  File "E:\Deploy_Kratos\KratosMultiphysics\FSIApplication\partitioned_fsi_base_solver.py", line 128, in PrepareModelPart
    self._GetFSICouplingInterfaceStructure().GetInterfaceModelPart()
  File "E:\Deploy_Kratos\KratosMultiphysics\FSIApplication\fsi_coupling_interface.py", line 92, in GetInterfaceModelPart
    self._fsi_interface_model_part = self._create_fsi_interface_model_part()
  File "E:\Deploy_Kratos\KratosMultiphysics\FSIApplication\fsi_coupling_interface.py", line 321, in _create_fsi_interface_model_part
    self._get_partitioned_fsi_utilities().CreateCouplingSkin(
RuntimeError: Error: Invalid points number. Expected 3, given 4




in kratos/geometries/triangle_3d_3.h:242:Triangle3D3<class Node<3,class Dof > >::Triangle3D3
   kratos/conditions/mesh_condition.cpp:96:MeshCondition::Create
   kratos/sources/model_part.cpp:1489:ModelPart::CreateNewCondition
   kratos/sources/model_part.cpp:1460:ModelPart::CreateNewCondition

mok3Dfails.gid.zip

I think it is because you meshed the structure with hexas instead of using tetras. Could this be the reason?

@jginternational
Copy link
Copy Markdown
Member Author

MOK 3D still fails:

Traceback (most recent call last):
  File "C:\Users\garat\Desktop\aaa.gid\MainKratos.py", line 35, in <module>
    simulation.Run()
  File "E:\Deploy_Kratos\KratosMultiphysics\analysis_stage.py", line 47, in Run
    self.Initialize()
  File "C:\Users\garat\Desktop\aaa.gid\MainKratos.py", line 16, in Initialize
    super().Initialize()
  File "E:\Deploy_Kratos\KratosMultiphysics\FSIApplication\fsi_analysis.py", line 23, in Initialize
    self._GetSolver().PrepareModelPart()
  File "E:\Deploy_Kratos\KratosMultiphysics\FSIApplication\partitioned_fsi_base_solver.py", line 128, in PrepareModelPart
    self._GetFSICouplingInterfaceStructure().GetInterfaceModelPart()
  File "E:\Deploy_Kratos\KratosMultiphysics\FSIApplication\fsi_coupling_interface.py", line 92, in GetInterfaceModelPart
    self._fsi_interface_model_part = self._create_fsi_interface_model_part()
  File "E:\Deploy_Kratos\KratosMultiphysics\FSIApplication\fsi_coupling_interface.py", line 321, in _create_fsi_interface_model_part
    self._get_partitioned_fsi_utilities().CreateCouplingSkin(
RuntimeError: Error: Invalid points number. Expected 3, given 4




in kratos/geometries/triangle_3d_3.h:242:Triangle3D3<class Node<3,class Dof > >::Triangle3D3
   kratos/conditions/mesh_condition.cpp:96:MeshCondition::Create
   kratos/sources/model_part.cpp:1489:ModelPart::CreateNewCondition
   kratos/sources/model_part.cpp:1460:ModelPart::CreateNewCondition

mok3Dfails.gid.zip

I think it is because you meshed the structure with hexas instead of using tetras. Could this be the reason?

Yes but we are using that hexas since... 2017

GiD_Process Mescape Meshing ElemType Hexahedra [GiD_EntitiesGroups get Structure volumes] escape

Added in the commit cd34f60

@rubenzorrilla
Copy link
Copy Markdown
Member

MOK 3D still fails:

Traceback (most recent call last):
  File "C:\Users\garat\Desktop\aaa.gid\MainKratos.py", line 35, in <module>
    simulation.Run()
  File "E:\Deploy_Kratos\KratosMultiphysics\analysis_stage.py", line 47, in Run
    self.Initialize()
  File "C:\Users\garat\Desktop\aaa.gid\MainKratos.py", line 16, in Initialize
    super().Initialize()
  File "E:\Deploy_Kratos\KratosMultiphysics\FSIApplication\fsi_analysis.py", line 23, in Initialize
    self._GetSolver().PrepareModelPart()
  File "E:\Deploy_Kratos\KratosMultiphysics\FSIApplication\partitioned_fsi_base_solver.py", line 128, in PrepareModelPart
    self._GetFSICouplingInterfaceStructure().GetInterfaceModelPart()
  File "E:\Deploy_Kratos\KratosMultiphysics\FSIApplication\fsi_coupling_interface.py", line 92, in GetInterfaceModelPart
    self._fsi_interface_model_part = self._create_fsi_interface_model_part()
  File "E:\Deploy_Kratos\KratosMultiphysics\FSIApplication\fsi_coupling_interface.py", line 321, in _create_fsi_interface_model_part
    self._get_partitioned_fsi_utilities().CreateCouplingSkin(
RuntimeError: Error: Invalid points number. Expected 3, given 4




in kratos/geometries/triangle_3d_3.h:242:Triangle3D3<class Node<3,class Dof > >::Triangle3D3
   kratos/conditions/mesh_condition.cpp:96:MeshCondition::Create
   kratos/sources/model_part.cpp:1489:ModelPart::CreateNewCondition
   kratos/sources/model_part.cpp:1460:ModelPart::CreateNewCondition

mok3Dfails.gid.zip

I think it is because you meshed the structure with hexas instead of using tetras. Could this be the reason?

Yes but we are using that hexas since... 2017

GiD_Process Mescape Meshing ElemType Hexahedra [GiD_EntitiesGroups get Structure volumes] escape

Added in the commit cd34f60

I know, but we improved the implementation (broking the hexas). Would you mind opening an issue so I can have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FSI Modelpart naming

2 participants