Skip to content

[ConstitutiveLawsApp] Adding more CL to the interface#885

Merged
AlejandroCornejo merged 18 commits intomasterfrom
adding-cl-structural
Aug 18, 2022
Merged

[ConstitutiveLawsApp] Adding more CL to the interface#885
AlejandroCornejo merged 18 commits intomasterfrom
adding-cl-structural

Conversation

@AlejandroCornejo
Copy link
Copy Markdown
Member

In this PR I'm adding several CL to the Structural ptype

@AlejandroCornejo AlejandroCornejo changed the title [ConstitutiveLawsApp] [ConstitutiveLawsApp] Adding more CL to the interface Aug 16, 2022
@AlejandroCornejo
Copy link
Copy Markdown
Member Author

@jginternational If there is something i need to change just let me know

</CLaw>

<!--Damage isotropic-->
<CLaw n="SmallStrainIsotropicDamage3DVonMisesVonMises" pn="Small Strain Isotropic damage" Type="3D" Behaviour="Damage" StrainSize="6" ImplementedInApplication="StructuralMechanicsApplication" help="Isotropic damage for 3d solids" Dimension="3D" LargeDeformation="False" RequiresLocalAxes="False" HybridType="False">
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd give few more details in the help.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a bit picky, but I'd add what are these VonMisesVonMises (I guess that these would be the failure surfaces or something of this sort). This nomenclature might be obvious for you but maybe it's not for the users of the GUI 😅 .

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, you're right. Gonna do it

@AlejandroCornejo
Copy link
Copy Markdown
Member Author

is now ready to go? :)

@loumalouomega
Copy link
Copy Markdown
Member

is now ready to go? :)

yes honey

@AlejandroCornejo AlejandroCornejo merged commit 5678647 into master Aug 18, 2022
@jginternational jginternational deleted the adding-cl-structural branch September 18, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants