Skip to content

[Structural] Adding "use_old_stiffness_in_first_iteration" to the GUI and false by default#891

Merged
AlejandroCornejo merged 4 commits intomasterfrom
adding-old-stiffness-by-default
Sep 18, 2022
Merged

[Structural] Adding "use_old_stiffness_in_first_iteration" to the GUI and false by default#891
AlejandroCornejo merged 4 commits intomasterfrom
adding-old-stiffness-by-default

Conversation

@AlejandroCornejo
Copy link
Copy Markdown
Member

@RiccardoRossi @rubenzorrilla @loumalouomega

As we know, in non-linear simulations in solids is mandatory to add always the "use_old_stiffness_in_first_iteration" to be true in the json in order to properly work.

In this PR I am adding this line an setting it to true always. De we agree on this?

Regards

Copy link
Copy Markdown
Member

@rubenzorrilla rubenzorrilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By doing it in this way you'll be setting it to true also in linear simulations. Besides, you're not exposing it to the GUI.

Instead, I'd expose this parameter in the GUI, making it active if a non-linear analysis is selected. You can default it to true in there.

@AlejandroCornejo
Copy link
Copy Markdown
Member Author

Now the parameter is set only in non_linear simulations. IMO, in non linear constitutive problems always should be true so I would not expose it to the GUI. If we need to expose it I'd need the help of @jginternational to do that :)

@rubenzorrilla
Copy link
Copy Markdown
Member

Now the parameter is set only in non_linear simulations. IMO, in non linear constitutive problems always should be true so I would not expose it to the GUI. If we need to expose it I'd need the help of @jginternational to do that :)

I think it must be exposed. Note that it has an extra computational cost, which might be not always required. You can default it to true. I don't think it is a good idea to hardcode it like this. If you want to hardcode things, the GiD GUI scripts is not the place as you will be only hardcoding for the GiD users. The place is the solver defaults.

@jginternational
Copy link
Copy Markdown
Member

I'd recommend the changes above so the parameter is shown in gui

@AlejandroCornejo
Copy link
Copy Markdown
Member Author

Now it is exposed to the GUI but set false by default.

@AlejandroCornejo
Copy link
Copy Markdown
Member Author

I think now should be fine right @rubenzorrilla ?

@jginternational jginternational self-requested a review September 17, 2022 10:56
@AlejandroCornejo AlejandroCornejo merged commit 80a4cb5 into master Sep 18, 2022
@AlejandroCornejo AlejandroCornejo changed the title [Structural] Adding "use_old_stiffness_in_first_iteration" as true by default [Structural] Adding "use_old_stiffness_in_first_iteration" to the GUI and false by default Sep 18, 2022
@jginternational jginternational deleted the adding-old-stiffness-by-default branch September 18, 2022 15:37
@rubenzorrilla
Copy link
Copy Markdown
Member

I think now should be fine right @rubenzorrilla ?

It is. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants